Page MenuHomePhabricator

Auto-complete of conditions will change rendering of existing value when swapping operation
Closed, ResolvedPublic

Description

Reproduce:

  1. Create new Herald Rule
  2. For Condition, select Author's Projects → include all of → Daemons
  3. From the operation dropdown change to include any of

Result:

  1. The value (Daemons) changes to o.

Screencap:

project-value.gif (477×1 px, 225 KB)

Revisions and Commits

Restricted Differential Revision

Event Timeline

I didn't add to Herald as I wasn't sure whether it's specific to these forms or if there are other forms which have these components and the same problem.

Yeah, these are "common" controls, but I think they only get used in Herald?

Herald has some very unusual code to preserve control values when you swap the selectors. Generally, the issue is:

  • when you change the <select /> controls in the first two columns, that may change the type of control in the third column (e.g., from a typeahead to a text field or to no control);
  • if the old and new controls are both of the same type, we try to transfer the value between them.

I'd guess something is off with the "copy the value" code.

epriestley added a revision: Restricted Differential Revision.Jan 21 2016, 7:10 PM
epriestley closed this task as Resolved by committing Restricted Diffusion Commit.Jan 21 2016, 8:17 PM
epriestley added a commit: Restricted Diffusion Commit.