Differential D15077

Make herald tokenizers copy values more correctly
ClosedPublic
Actions

Authored by epriestley on Jan 21 2016, 7:10 PM.

Details

Reviewers

chad

Maniphest Tasks

T10190: Auto-complete of conditions will change rendering of existing value when swapping operation

Commits

Restricted Diffusion Commit
rP7bf4ef451b3f: Make herald tokenizers copy values more correctly

Summary

Fixes T10190. This is still a touch weird (newly typed tokens lose icons when copied) but basically works correctly. Saving/editing rules is fine, just some minor display glitching.

Fixing the icon thing is a little more involved.

Test Plan

Swapped Herald tokenizer fields around saw values (approximately) preserved.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 36403.Jan 21 2016, 7:10 PM

epriestley retitled this revision from to Make herald tokenizers copy values more correctly.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T10190: Auto-complete of conditions will change rendering of existing value when swapping operation.

chad accepted this revision.Jan 21 2016, 8:03 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Jan 21 2016, 8:03 PM

Closed by commit rP7bf4ef451b3f: Make herald tokenizers copy values more correctly (authored by epriestley, committed by epriestley). · Explain WhyJan 21 2016, 8:17 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

resources/

celerity/

map.php

22 lines

webroot/

rsrc/

js/

application/

herald/

HeraldRuleEditor.js

12 lines

Diff 36405

View Options

resources/celerity/map.php