Differential D16044

After toggling DarkConsole, force a user settings cache fill
ClosedPublic
Actions

Authored by epriestley on Jun 5 2016, 1:58 PM.

Details

Reviewers

chad

Maniphest Tasks

T10078: Implement global readthrough cache pools

Commits

rPaa4ba0fa92c1: After toggling DarkConsole, force a user settings cache fill

Summary

Ref T10078. Currently, you toggle DarkConsole and then load a page, but on the load we have to refill your settings cache since toggling DarkConsole dirtied it.

This is fine, except that it makes it harder to understand what's going on with queries on a page. Just force it to reload right away instead.

Test Plan

Toggled DarkConsole, reloaded page, no longer saw settings toggle-related cache fill.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 38598.Jun 5 2016, 1:58 PM

epriestley retitled this revision from to After toggling DarkConsole, force a user settings cache fill.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T10078: Implement global readthrough cache pools.

chad accepted this revision.Jun 5 2016, 4:23 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Jun 5 2016, 4:23 PM

Closed by commit rPaa4ba0fa92c1: After toggling DarkConsole, force a user settings cache fill (authored by epriestley, committed by epriestley). · Explain WhyJun 5 2016, 5:04 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

console/

controller/

DarkConsoleController.php

11 lines

Diff 38610

View Options

src/applications/console/controller/DarkConsoleController.php

After toggling DarkConsole, force a user settings cache fillClosedPublicActions