Page MenuHomePhabricator

Best practice for Audit
Closed, ResolvedPublic

Asked by taoqiping on Sep 11 2014, 4:47 AM.

Details

Not sure where it is active here, here I want to search for a best practice for Audit.
because we have dynamic/developer repository, and arc seems a little hard to enforce into team at first beginning, So I want to enforce audit as code review process in team.

but because audit is by commit;
If reviewer add some comments, and raise concern to author, then author fix comments and check-in again. but then the check-in will be another audit request and even with no relation with previous one. how can we make it behave like arc diff, to check check-in in one series, and with full context in audit.

what is best practice here, any suggestion is appreciated.

Answers

sshannin
Updated 1,547 Days Ago

We've mostly converted to differential, but still wind up doing post-commit for some things.

I usually just comment on the first audit with the revision of the second to link them.

New Answer

Answer

This question has been marked as closed, but you can still leave a new answer.