Allow to add relations between commits.
This is useful if you only use audit reviews and
want to add some information when something is fixed
in antoher commit.
Fixes T4026
Details
Details
- Reviewers
epriestley - Group Reviewers
Blessed Reviewers - Maniphest Tasks
- T4026: Add relations between commits
Go to a commit and add a relation
to another commit.
Diff Detail
Diff Detail
- Branch
- master
- Lint
Lint Warnings Severity Location Code Message Warning src/applications/diffusion/controller/DiffusionCommitController.php:428 TXT3 Line Too Long Warning src/applications/diffusion/controller/DiffusionCommitController.php:430 TXT3 Line Too Long - Unit
Tests Passed
Event Timeline
Comment Actions
The only two "relationships" I've seen in the wild are "X fixes Y" and "X reverts Y". Do you have more than this?
I'd like to formalize "fixes" and "reverts" as first-class relationships. They're relevant for us in other cases (i.e., Diffusion and other applications like Differential and arc can work better if they know that two commits are related by "X reverts Y" than if they just know that they're related), and we can derive them automatically in some cases.
D5846 adds (and automatically populates) a "reverts" relationship, although it needed a bit more work so I never finished it.
T2542 discusses formalizing the "fixes" relationship.
Are there other relationships here, beyond "reverts" and "fixes"?
Comment Actions
Are there other relationships here, beyond "reverts" and "fixes"?
I don't think so. Im fine with your changes.