Page MenuHomePhabricator

Add relations between commits
Needs RevisionPublic

Authored by sascha-egerer on Oct 26 2013, 5:29 PM.

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T4026: Add relations between commits
Summary

Allow to add relations between commits.
This is useful if you only use audit reviews and
want to add some information when something is fixed
in antoher commit.

Fixes T4026

Test Plan

Go to a commit and add a relation
to another commit.

Diff Detail

Branch
master
Lint
Lint WarningsExcuse: Constant name is that long
Unit
Unit Tests OK

Event Timeline

epriestley requested changes to this revision.Nov 4 2013, 6:14 PM

The only two "relationships" I've seen in the wild are "X fixes Y" and "X reverts Y". Do you have more than this?

I'd like to formalize "fixes" and "reverts" as first-class relationships. They're relevant for us in other cases (i.e., Diffusion and other applications like Differential and arc can work better if they know that two commits are related by "X reverts Y" than if they just know that they're related), and we can derive them automatically in some cases.

D5846 adds (and automatically populates) a "reverts" relationship, although it needed a bit more work so I never finished it.

T2542 discusses formalizing the "fixes" relationship.

Are there other relationships here, beyond "reverts" and "fixes"?

Are there other relationships here, beyond "reverts" and "fixes"?

I don't think so. Im fine with your changes.