Page MenuHomePhabricator
Differential D9989

Don't explicitly name abstract base classes
ClosedPublic
Actions

Authored by joshuaspence on Jul 20 2014, 10:40 AM.
Tags
None
Referenced Files
F15453948: D9989.diff
Sat, Mar 29, 3:16 PM
F15449795: D9989.id.diff
Fri, Mar 28, 12:20 PM
F15441384: D9989.id.diff
Wed, Mar 26, 5:54 PM
F15435731: D9989.diff
Tue, Mar 25, 9:59 AM
F15433430: D9989.id.diff
Mon, Mar 24, 11:07 PM
F15425695: D9989.id.diff
Sun, Mar 23, 5:31 AM
F15423437: D9989.id24028.diff
Sat, Mar 22, 3:26 PM
F15402303: D9989.id24007.diff
Mon, Mar 17, 9:51 PM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T5655: Standardize naming conventions
Commits
Restricted Diffusion Commit
rP37106c1b3178: Don't explicitly name abstract base classes
Summary

Ref T5655. It is superfluous to include "base" in the name of an abstract base class. Furthermore, it is not done consistently within the code base.

Test Plan

Ran arc unit.

Diff Detail

Repository
rP Phabricator
Branch
base
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 1792
Build 1793: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence updated this revision to Diff 24007.Jul 20 2014, 10:40 AM
joshuaspence retitled this revision from to Don't explicitly name abstract base classes.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
joshuaspence added a task: T5655: Standardize naming conventions.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJul 20 2014, 10:40 AM
Herald added subscribers: Korvin, epriestley. · View Herald Transcript
Harbormaster completed remote builds in B1792: Diff 24007.Jul 20 2014, 10:41 AM
epriestley accepted this revision.Jul 21 2014, 1:26 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Jul 21 2014, 1:26 PM
joshuaspence closed this revision.Jul 21 2014, 2:05 PM
joshuaspence updated this revision to Diff 24028.

Closed by commit rP37106c1b3178 (authored by @joshuaspence).

Revision Contents
Changeset List

Diff 24007

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/oauthserver/controller/client/PhabricatorOAuthClientBaseController.php

Loading...
View Options

src/applications/oauthserver/controller/client/PhabricatorOAuthClientController.php

Loading...
View Options

src/applications/oauthserver/controller/client/PhabricatorOAuthClientDeleteController.php

Loading...
View Options

src/applications/oauthserver/controller/client/PhabricatorOAuthClientEditController.php

Loading...
View Options

src/applications/oauthserver/controller/client/PhabricatorOAuthClientListController.php

Loading...
View Options

src/applications/oauthserver/controller/client/PhabricatorOAuthClientViewController.php

Loading...
Phabricator · Built by Phacility