Page MenuHomePhabricator
Differential D9985

Simplify the implementation of `PhabricatorPHIDType` subclasses
ClosedPublic
Actions

Authored by joshuaspence on Jul 19 2014, 6:35 AM.
Tags
None
Referenced Files
F14838060: D9985.diff
Fri, Jan 31, 1:15 PM
F14837977: D9985.id23994.diff
Fri, Jan 31, 12:42 PM
F14836179: D9985.id.diff
Fri, Jan 31, 12:52 AM
Unknown Object (File)
Tue, Jan 28, 8:36 AM
Unknown Object (File)
Tue, Jan 28, 12:57 AM
Unknown Object (File)
Mon, Jan 27, 6:58 AM
Unknown Object (File)
Wed, Jan 22, 7:55 PM
Unknown Object (File)
Tue, Jan 21, 10:44 PM
View All Files
Subscribers
epriestley
hach-que
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Commits
Restricted Diffusion Commit
rP254542237a66: Simplify the implementation of `PhabricatorPHIDType` subclasses
Summary

Instead of implementing the getTypeConstant method in all subclasses of PhabricatorPHIDType, provide a final implementation in the base class which uses reflection. See D9837 for a similar implementation.

Test Plan

Ran arc unit.

Diff Detail

Repository
rP Phabricator
Branch
phidtype-reflection
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 1783
Build 1784: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence updated this revision to Diff 23994.Jul 19 2014, 6:35 AM
joshuaspence retitled this revision from to Simplify the implementation of `PhabricatorPHIDType` subclasses.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJul 19 2014, 6:35 AM
Herald added subscribers: hach-que, Korvin, epriestley. · View Herald Transcript
Harbormaster completed remote builds in B1782: Diff 23994.Jul 19 2014, 6:36 AM
joshuaspence updated this revision to Diff 23995.Jul 19 2014, 8:40 AM
joshuaspence edited edge metadata.
  • Simplify conditional by using preg_match
Harbormaster completed remote builds in B1783: Diff 23995.Jul 19 2014, 8:41 AM
epriestley accepted this revision.Jul 21 2014, 2:03 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Jul 21 2014, 2:03 PM
joshuaspence closed this revision.Jul 21 2014, 2:38 PM
joshuaspence updated this revision to Diff 24031.

Closed by commit rP254542237a66 (authored by @joshuaspence).

Revision Contents
Changeset List

PathSize
src/
applications/
auth/
phid/
4 lines
calendar/
phid/
4 lines
config/
phid/
4 lines
conpherence/
phid/
4 lines
countdown/
phid/
4 lines
dashboard/
phid/
4 lines
4 lines
differential/
phid/
4 lines
4 lines
diviner/
phid/
4 lines
4 lines
drydock/
phid/
4 lines
4 lines
4 lines
files/
phid/
4 lines
harbormaster/
phid/
4 lines
4 lines
4 lines
4 lines
4 lines
4 lines
4 lines
herald/
phid/
4 lines
legalpad/
phid/
4 lines
macro/
phid/
4 lines
mailinglists/
phid/
4 lines
maniphest/
phid/
4 lines
meta/
phid/
4 lines
nuance/
phid/
7 lines
4 lines
7 lines
7 lines
oauthserver/
phid/
4 lines
4 lines
owners/
phid/
4 lines
passphrase/
phid/
4 lines
paste/
phid/
4 lines
people/
phid/
4 lines
4 lines
phame/
phid/
4 lines
4 lines
phid/
type/
23 lines
phlux/
phid/
4 lines
pholio/
phid/
4 lines
4 lines
phragment/
phid/
7 lines
7 lines
7 lines
phriction/
phid/
4 lines
policy/
phid/
7 lines
ponder/
phid/
4 lines
4 lines
project/
phid/
4 lines
4 lines
releeph/
phid/
4 lines
4 lines
4 lines
repository/
phid/
4 lines
4 lines
7 lines
7 lines
7 lines
4 lines
slowvote/
phid/
4 lines
tokens/
phid/
4 lines
transactions/
phid/
4 lines

Diff 23995

View Options

src/applications/auth/phid/PhabricatorAuthPHIDTypeAuthFactor.php

Loading...
View Options

src/applications/calendar/phid/PhabricatorCalendarPHIDTypeEvent.php

Loading...
View Options

src/applications/config/phid/PhabricatorConfigPHIDTypeConfig.php

Loading...
View Options

src/applications/conpherence/phid/PhabricatorConpherencePHIDTypeThread.php

Loading...
View Options

src/applications/countdown/phid/PhabricatorCountdownPHIDTypeCountdown.php

Loading...
View Options

src/applications/dashboard/phid/PhabricatorDashboardPHIDTypeDashboard.php

Loading...
View Options

src/applications/dashboard/phid/PhabricatorDashboardPHIDTypePanel.php

Loading...
View Options

src/applications/differential/phid/DifferentialPHIDTypeDiff.php

Loading...
View Options

src/applications/differential/phid/DifferentialPHIDTypeRevision.php

Loading...
View Options

src/applications/diviner/phid/DivinerPHIDTypeAtom.php

Loading...
View Options

src/applications/diviner/phid/DivinerPHIDTypeBook.php

Loading...
View Options

src/applications/drydock/phid/DrydockPHIDTypeBlueprint.php

Loading...
View Options

src/applications/drydock/phid/DrydockPHIDTypeLease.php

Loading...
View Options

src/applications/drydock/phid/DrydockPHIDTypeResource.php

Loading...
View Options

src/applications/files/phid/PhabricatorFilePHIDTypeFile.php

Loading...
View Options

src/applications/harbormaster/phid/HarbormasterPHIDTypeBuild.php

Loading...
View Options

src/applications/harbormaster/phid/HarbormasterPHIDTypeBuildItem.php

Loading...
View Options

src/applications/harbormaster/phid/HarbormasterPHIDTypeBuildLog.php

Loading...
View Options

src/applications/harbormaster/phid/HarbormasterPHIDTypeBuildPlan.php

Loading...
View Options

src/applications/harbormaster/phid/HarbormasterPHIDTypeBuildStep.php

Loading...
View Options

src/applications/harbormaster/phid/HarbormasterPHIDTypeBuildTarget.php

Loading...
View Options

src/applications/harbormaster/phid/HarbormasterPHIDTypeBuildable.php

Loading...
View Options

src/applications/herald/phid/HeraldPHIDTypeRule.php

Loading...
View Options

src/applications/legalpad/phid/PhabricatorLegalpadPHIDTypeDocument.php

Loading...
View Options

src/applications/macro/phid/PhabricatorMacroPHIDTypeMacro.php

Loading...
View Options

src/applications/mailinglists/phid/PhabricatorMailingListPHIDTypeList.php

Loading...
View Options

src/applications/maniphest/phid/ManiphestPHIDTypeTask.php

Loading...
View Options

src/applications/meta/phid/PhabricatorApplicationPHIDTypeApplication.php

Loading...
View Options

src/applications/nuance/phid/NuancePHIDTypeItem.php

Loading...
View Options

src/applications/nuance/phid/NuancePHIDTypeQueue.php

Loading...
View Options

src/applications/nuance/phid/NuancePHIDTypeRequestor.php

Loading...
View Options

src/applications/nuance/phid/NuancePHIDTypeSource.php

Loading...
View Options

src/applications/oauthserver/phid/PhabricatorOAuthServerPHIDTypeClient.php

Loading...
View Options

src/applications/oauthserver/phid/PhabricatorOAuthServerPHIDTypeClientAuthorization.php

Loading...
View Options

src/applications/owners/phid/PhabricatorOwnersPHIDTypePackage.php

Loading...
View Options

src/applications/passphrase/phid/PassphrasePHIDTypeCredential.php

Loading...
View Options

src/applications/paste/phid/PhabricatorPastePHIDTypePaste.php

Loading...
View Options

src/applications/people/phid/PhabricatorPeoplePHIDTypeExternal.php

Loading...
View Options

src/applications/people/phid/PhabricatorPeoplePHIDTypeUser.php

Loading...
View Options

src/applications/phame/phid/PhabricatorPhamePHIDTypeBlog.php

Loading...
View Options

src/applications/phame/phid/PhabricatorPhamePHIDTypePost.php

Loading...
View Options

src/applications/phid/type/PhabricatorPHIDType.php

Loading...
View Options

src/applications/phlux/phid/PhluxPHIDTypeVariable.php

Loading...
View Options

src/applications/pholio/phid/PholioPHIDTypeImage.php

Loading...
View Options

src/applications/pholio/phid/PholioPHIDTypeMock.php

Loading...
View Options

src/applications/phragment/phid/PhragmentPHIDTypeFragment.php

Loading...
View Options

src/applications/phragment/phid/PhragmentPHIDTypeFragmentVersion.php

Loading...
View Options

src/applications/phragment/phid/PhragmentPHIDTypeSnapshot.php

Loading...
View Options

src/applications/phriction/phid/PhrictionPHIDTypeDocument.php

Loading...
View Options

src/applications/policy/phid/PhabricatorPolicyPHIDTypePolicy.php

Loading...
View Options

src/applications/ponder/phid/PonderPHIDTypeAnswer.php

Loading...
View Options

src/applications/ponder/phid/PonderPHIDTypeQuestion.php

Loading...
View Options

src/applications/project/phid/PhabricatorProjectPHIDTypeColumn.php

Loading...
View Options

src/applications/project/phid/PhabricatorProjectPHIDTypeProject.php

Loading...
View Options

src/applications/releeph/phid/ReleephPHIDTypeBranch.php

Loading...
View Options

src/applications/releeph/phid/ReleephPHIDTypeProduct.php

Loading...
View Options

src/applications/releeph/phid/ReleephPHIDTypeRequest.php

Loading...
View Options

src/applications/repository/phid/PhabricatorRepositoryPHIDTypeArcanistProject.php

Loading...
View Options

src/applications/repository/phid/PhabricatorRepositoryPHIDTypeCommit.php

Loading...
View Options

src/applications/repository/phid/PhabricatorRepositoryPHIDTypeMirror.php

Loading...
View Options

src/applications/repository/phid/PhabricatorRepositoryPHIDTypePushEvent.php

Loading...
View Options

src/applications/repository/phid/PhabricatorRepositoryPHIDTypePushLog.php

Loading...
View Options

src/applications/repository/phid/PhabricatorRepositoryPHIDTypeRepository.php

Loading...
View Options

src/applications/slowvote/phid/PhabricatorSlowvotePHIDTypePoll.php

Loading...
View Options

src/applications/tokens/phid/PhabricatorTokenPHIDTypeToken.php

Loading...
View Options

src/applications/transactions/phid/PhabricatorApplicationTransactionPHIDTypeTransaction.php

Loading...
Phabricator · Built by Phacility