Page MenuHomePhabricator

Simplify the implementation of `PhabricatorPHIDType` subclasses
ClosedPublic

Authored by joshuaspence on Jul 19 2014, 6:35 AM.
Tags
None
Referenced Files
F10771592: D9985.id23995.diff
Sat, May 28, 11:50 AM
F10770290: D9985.diff
Sat, May 28, 3:32 AM
Unknown Object (File)
Wed, May 25, 7:56 AM
Unknown Object (File)
Mar 11 2017, 3:27 AM
Unknown Object (File)
Feb 16 2017, 1:23 PM
Unknown Object (File)
Feb 16 2017, 1:23 PM
Unknown Object (File)
Feb 16 2017, 1:23 PM
Unknown Object (File)
Feb 16 2017, 1:23 PM

Details

Summary

Instead of implementing the getTypeConstant method in all subclasses of PhabricatorPHIDType, provide a final implementation in the base class which uses reflection. See D9837 for a similar implementation.

Test Plan

Ran arc unit.

Diff Detail

Repository
rP Phabricator
Branch
phidtype-reflection
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 1783
Build 1784: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence retitled this revision from to Simplify the implementation of `PhabricatorPHIDType` subclasses.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
joshuaspence edited edge metadata.
  • Simplify conditional by using preg_match
epriestley edited edge metadata.
This revision is now accepted and ready to land.Jul 21 2014, 2:03 PM
joshuaspence updated this revision to Diff 24031.

Closed by commit rP254542237a66 (authored by @joshuaspence).