Page MenuHomePhabricator

Remove `@group` annotations
ClosedPublic

Authored by joshuaspence on Jul 9 2014, 8:51 PM.
Tags
None
Referenced Files
F18807765: D9859.diff
Sun, Oct 19, 3:26 AM
F18661386: D9859.id23678.diff
Tue, Sep 23, 7:38 PM
F18627759: D9859.largetrue.diff
Sep 16 2025, 4:42 AM
F18616927: D9859.largetrue.diff
Sep 14 2025, 7:34 PM
F18596849: D9859.diff
Sep 13 2025, 1:37 AM
F18587335: D9859.diff
Sep 11 2025, 9:05 PM
F18558023: D9859.id.diff
Sep 8 2025, 8:15 PM
F18515195: D9859.diff
Sep 5 2025, 11:04 AM

Details

Reviewers
epriestley
chad
Group Reviewers
Blessed Reviewers
Commits
Restricted Diffusion Commit
rP8756d82cf6c1: Remove `@group` annotations
Summary

I'm pretty sure that @group annotations are useless now... see D9855. Also fixed various other minor issues.

Test Plan

Eye-ball it.

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

joshuaspence retitled this revision from to Remove `@group` annotations.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
epriestley edited edge metadata.
This revision is now accepted and ready to land.Jul 9 2014, 9:48 PM
joshuaspence edited edge metadata.
  • Found two more... maybe these functions need to be moved? (I don't really know)
joshuaspence updated this revision to Diff 23678.

Closed by commit rP8756d82cf6c1 (authored by @joshuaspence).