Paths

Table of Contentst

Differential D9855

Remove `@group` annotations
ClosedPublic
Actions

Authored by joshuaspence on Jul 8 2014, 12:59 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Wed, Nov 20, 5:14 PM

	Unknown Object (File)
	Wed, Nov 20, 4:03 AM

	Unknown Object (File)
	Sat, Nov 2, 7:46 AM

	Unknown Object (File)
	Wed, Oct 30, 1:18 PM

	Unknown Object (File)
	Wed, Oct 30, 1:17 PM

	Unknown Object (File)
	Wed, Oct 30, 1:16 PM

	Unknown Object (File)
	Wed, Oct 30, 12:52 PM

	Unknown Object (File)
	Sat, Oct 26, 11:13 AM

Subscribers

Details

Reviewers

Group Reviewers

Blessed Reviewers

Commits

rARCd09beeb75c3e: Remove `@group` annotations

Summary

I'm pretty sure that @group annotations are useless now... I believe that they were originally used by Diviner?

Test Plan

Eye-balled it.

Diff Detail

Repository

Branch

rm_group

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 1578
Build 1579: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence updated this revision to Diff 23648.Jul 8 2014, 12:59 PM

joshuaspence retitled this revision from to Remove `@group` annotations.

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJul 8 2014, 12:59 PM

Herald added subscribers: aurelijus, Korvin, epriestley. · View Herald Transcript

Harbormaster completed remote builds in B1578: Diff 23648.Jul 8 2014, 1:00 PM

Yeah, Diviner can figure out @group from configuration now. It's still parsed, but only useful to override the defaults if some file has an unusual grouping for some reason (which nothing in these libraries should, I think).

This revision is now accepted and ready to land.Jul 8 2014, 2:42 PM

In D9855#6, @epriestley wrote:

Yeah, Diviner can figure out @group from configuration now. It's still parsed, but only useful to override the defaults if some file has an unusual grouping for some reason (which nothing in these libraries should, I think).

Is there an easy way to identify these?

Closed by commit rARCd09beeb75c3e (authored by @joshuaspence).

I don't have any way to identify them if they do exist. They would have to be weird edge cases that I annotated and then forgot about. If there are any, they're so rare that it's not worth trying to find them. We can add them back if necessary later, but more likely we'd just want to move the code now.

The only case like this that I can think of is all the stuff that used to live in libphutil/src/__phutil_library_init__.php -- moving it out was clearly a better approach.

Large Diff

This large diff affects 123 files. Files without inline comments have been collapsed. Expand All Files

Revision Contents
Changeset List

Path

Size

scripts/

__init_script__.php

1 line

src/

configuration/

ArcanistConfiguration.php

8 lines

ArcanistConfigurationManager.php

2 lines

ArcanistSettings.php

5 lines

__tests__/

ArcanistBritishTestCase.php

1 line

difference/

ArcanistDiffUtils.php

2 lines

__tests__/

ArcanistDiffUtilsTestCase.php

94 lines

differential/

ArcanistDifferentialCommitMessage.php

2 lines

ArcanistDifferentialCommitMessageParserException.php

2 lines

events/

constant/

ArcanistEventType.php

1 line

exception/

ArcanistChooseInvalidRevisionException.php

6 lines

ArcanistChooseNoRevisionsException.php

6 lines

ArcanistUsageException.php

5 lines

usage/

ArcanistNoEffectException.php

5 lines

ArcanistNoEngineException.php

5 lines

ArcanistUserAbortException.php

4 lines

hgdaemon/

ArcanistHgProxyClient.php

1 line

ArcanistHgProxyServer.php

1 line

lint/

ArcanistLintMessage.php

2 lines

ArcanistLintPatcher.php

2 lines

ArcanistLintResult.php

3 lines

ArcanistLintSeverity.php

4 lines

engine/

ArcanistLintEngine.php

8 lines

ArcanistSingleLintEngine.php

3 lines

ComprehensiveLintEngine.php

4 lines

UnitTestableArcanistLintEngine.php

2 lines

linter/

ArcanistCSharpLinter.php

18 lines

ArcanistConduitLinter.php

7 lines

ArcanistJSONLintLinter.php

1 line

ArcanistLinter.php

1 line

ArcanistMergeConflictLinter.php

1 line

ArcanistPhpcsLinter.php

2 lines

ArcanistPuppetLintLinter.php

1 line

ArcanistPyLintLinter.php

14 lines

ArcanistScriptAndRegexLinter.php

2 lines

ArcanistXHPASTLinter.php

4 lines

__tests__/

ArcanistLinterTestCase.php

1 line

xhpast/

ArcanistXHPASTLintNamingHook.php

5 lines

ArcanistXHPASTLintSwitchHook.php

2 lines

__tests__/

ArcanistXHPASTLintNamingHookTestCase.php

2 lines

renderer/

ArcanistLintCheckstyleXMLRenderer.php

3 lines

ArcanistLintConsoleRenderer.php

8 lines

ArcanistLintJSONRenderer.php

4 lines

ArcanistLintLikeCompilerRenderer.php

4 lines

ArcanistLintNoneRenderer.php

3 lines

ArcanistLintRenderer.php

2 lines

ArcanistLintSummaryRenderer.php

8 lines

parser/

ArcanistBaseCommitParser.php

1 line

ArcanistBundle.php

8 lines

ArcanistDiffParser.php

4 lines

__tests__/

ArcanistDiffParserTestCase.php

2 lines

diff/

ArcanistDiffChange.php

2 lines

ArcanistDiffChangeType.php

3 lines

ArcanistDiffHunk.php

2 lines

repository/

api/

ArcanistGitAPI.php

8 lines

ArcanistMercurialAPI.php

32 lines

ArcanistRepositoryAPI.php

1 line

ArcanistSubversionAPI.php

5 lines

__tests__/

ArcanistRepositoryAPIStateTestCase.php

1 line

hookapi/

ArcanistHookAPI.php

4 lines

ArcanistSubversionHookAPI.php

1 line

parser/

ArcanistMercurialParser.php

1 line

__tests__/

ArcanistMercurialParserTestCase.php

1 line

unit/

ArcanistUnitTestResult.php

6 lines

engine/

ArcanistBaseTestResultParser.php

7 lines

ArcanistBaseUnitTestEngine.php

11 lines

ArcanistXUnitTestResultParser.php

11 lines

CSharpToolsTestEngine.php

36 lines

GoTestResultParser.php

10 lines

NoseTestEngine.php

13 lines

PhpunitResultParser.php

12 lines

PhpunitTestEngine.php

20 lines

PhutilUnitTestEngine.php

2 lines

PytestTestEngine.php

14 lines

XUnitTestEngine.php

40 lines

__tests__/

GoTestResultParserTestCase.php

6 lines

PHPUnitTestEngineTestCase.php

3 lines

PhutilUnitTestEngineTestCase.php

2 lines

XUnitTestResultParserTestCase.php

5 lines

phutil/

ArcanistPhutilTestCase.php

4 lines

testcase/

ArcanistPhutilTestCaseTestCase.php

2 lines

ArcanistPhutilTestSkippedException.php

2 lines

ArcanistPhutilTestTerminatedException.php

2 lines

renderer/

ArcanistUnitConsoleRenderer.php

3 lines

ArcanistUnitRenderer.php

3 lines

workflow/

ArcanistAliasWorkflow.php

2 lines

ArcanistAnoidWorkflow.php

3 lines

ArcanistBackoutWorkflow.php

39 lines

ArcanistBaseWorkflow.php

14 lines

ArcanistBookmarkWorkflow.php

4 lines

ArcanistBranchWorkflow.php

4 lines

ArcanistBrowseWorkflow.php

1 line

ArcanistCallConduitWorkflow.php

3 lines

ArcanistCloseRevisionWorkflow.php

3 lines

ArcanistCloseWorkflow.php

9 lines

ArcanistCommitWorkflow.php

3 lines

ArcanistCoverWorkflow.php

3 lines

ArcanistDiffWorkflow.php

2 lines

ArcanistDownloadWorkflow.php

2 lines

ArcanistExportWorkflow.php

12 lines

ArcanistFeatureWorkflow.php

3 lines

ArcanistFlagWorkflow.php

11 lines

ArcanistGitHookPreReceiveWorkflow.php

3 lines

ArcanistHelpWorkflow.php

2 lines

ArcanistInlinesWorkflow.php

4 lines

ArcanistInstallCertificateWorkflow.php

3 lines

ArcanistLandWorkflow.php

96 lines

ArcanistLiberateWorkflow.php

8 lines

ArcanistLintWorkflow.php

8 lines

ArcanistListWorkflow.php

3 lines

ArcanistPasteWorkflow.php

2 lines

ArcanistPatchWorkflow.php

58 lines

ArcanistRevertWorkflow.php

6 lines

ArcanistSetConfigWorkflow.php

4 lines

ArcanistShellCompleteWorkflow.php

3 lines

ArcanistSvnHookPreCommitWorkflow.php

4 lines

ArcanistTasksWorkflow.php

8 lines

ArcanistTodoWorkflow.php

4 lines

ArcanistUnitWorkflow.php

3 lines

ArcanistUpgradeWorkflow.php

2 lines

ArcanistUploadWorkflow.php

3 lines

ArcanistWhichWorkflow.php

1 line

workingcopyidentity/

ArcanistWorkingCopyIdentity.php

7 lines

Diff 23648

scripts/__init_script__.php

src/configuration/ArcanistConfiguration.php

src/configuration/ArcanistConfigurationManager.php

src/configuration/ArcanistSettings.php

src/configuration/tests/ArcanistBritishTestCase.php

src/difference/ArcanistDiffUtils.php

src/difference/tests/ArcanistDiffUtilsTestCase.php

src/differential/ArcanistDifferentialCommitMessage.php

src/differential/ArcanistDifferentialCommitMessageParserException.php

src/events/constant/ArcanistEventType.php

src/exception/ArcanistChooseInvalidRevisionException.php

src/exception/ArcanistChooseNoRevisionsException.php

src/exception/ArcanistUsageException.php

src/exception/usage/ArcanistNoEffectException.php

src/exception/usage/ArcanistNoEngineException.php

src/exception/usage/ArcanistUserAbortException.php

src/hgdaemon/ArcanistHgProxyClient.php

src/hgdaemon/ArcanistHgProxyServer.php

src/lint/ArcanistLintMessage.php

src/lint/ArcanistLintPatcher.php

src/lint/ArcanistLintResult.php

src/lint/ArcanistLintSeverity.php

src/lint/engine/ArcanistLintEngine.php

src/lint/engine/ArcanistSingleLintEngine.php

src/lint/engine/ComprehensiveLintEngine.php

src/lint/engine/UnitTestableArcanistLintEngine.php

src/lint/linter/ArcanistCSharpLinter.php

src/lint/linter/ArcanistConduitLinter.php

src/lint/linter/ArcanistJSONLintLinter.php

src/lint/linter/ArcanistLinter.php

src/lint/linter/ArcanistMergeConflictLinter.php

src/lint/linter/ArcanistPhpcsLinter.php

src/lint/linter/ArcanistPuppetLintLinter.php

src/lint/linter/ArcanistPyLintLinter.php

src/lint/linter/ArcanistScriptAndRegexLinter.php

src/lint/linter/ArcanistXHPASTLinter.php

src/lint/linter/tests/ArcanistLinterTestCase.php

src/lint/linter/xhpast/ArcanistXHPASTLintNamingHook.php

src/lint/linter/xhpast/ArcanistXHPASTLintSwitchHook.php

src/lint/linter/xhpast/tests/ArcanistXHPASTLintNamingHookTestCase.php

src/lint/renderer/ArcanistLintCheckstyleXMLRenderer.php

src/lint/renderer/ArcanistLintConsoleRenderer.php

src/lint/renderer/ArcanistLintJSONRenderer.php

src/lint/renderer/ArcanistLintLikeCompilerRenderer.php

src/lint/renderer/ArcanistLintNoneRenderer.php

src/lint/renderer/ArcanistLintRenderer.php

src/lint/renderer/ArcanistLintSummaryRenderer.php

src/parser/ArcanistBaseCommitParser.php

src/parser/ArcanistBundle.php

src/parser/ArcanistDiffParser.php

src/parser/tests/ArcanistDiffParserTestCase.php

src/parser/diff/ArcanistDiffChange.php

src/parser/diff/ArcanistDiffChangeType.php

src/parser/diff/ArcanistDiffHunk.php

src/repository/api/ArcanistGitAPI.php

src/repository/api/ArcanistMercurialAPI.php

src/repository/api/ArcanistRepositoryAPI.php

src/repository/api/ArcanistSubversionAPI.php

src/repository/api/tests/ArcanistRepositoryAPIStateTestCase.php

src/repository/hookapi/ArcanistHookAPI.php

src/repository/hookapi/ArcanistSubversionHookAPI.php

src/repository/parser/ArcanistMercurialParser.php

src/repository/parser/tests/ArcanistMercurialParserTestCase.php

src/unit/ArcanistUnitTestResult.php

src/unit/engine/ArcanistBaseTestResultParser.php

src/unit/engine/ArcanistBaseUnitTestEngine.php

src/unit/engine/ArcanistXUnitTestResultParser.php

src/unit/engine/CSharpToolsTestEngine.php

src/unit/engine/GoTestResultParser.php

src/unit/engine/NoseTestEngine.php

src/unit/engine/PhpunitResultParser.php

src/unit/engine/PhpunitTestEngine.php

src/unit/engine/PhutilUnitTestEngine.php

src/unit/engine/PytestTestEngine.php

src/unit/engine/XUnitTestEngine.php

src/unit/engine/tests/GoTestResultParserTestCase.php

src/unit/engine/tests/PHPUnitTestEngineTestCase.php

src/unit/engine/tests/PhutilUnitTestEngineTestCase.php

src/unit/engine/tests/XUnitTestResultParserTestCase.php

src/unit/engine/phutil/ArcanistPhutilTestCase.php

src/unit/engine/phutil/testcase/ArcanistPhutilTestCaseTestCase.php

src/unit/engine/phutil/testcase/ArcanistPhutilTestSkippedException.php

src/unit/engine/phutil/testcase/ArcanistPhutilTestTerminatedException.php

src/unit/renderer/ArcanistUnitConsoleRenderer.php

src/unit/renderer/ArcanistUnitRenderer.php

src/workflow/ArcanistAliasWorkflow.php

src/workflow/ArcanistAnoidWorkflow.php

src/workflow/ArcanistBackoutWorkflow.php

src/workflow/ArcanistBaseWorkflow.php

src/workflow/ArcanistBookmarkWorkflow.php

src/workflow/ArcanistBranchWorkflow.php

src/workflow/ArcanistBrowseWorkflow.php

src/workflow/ArcanistCallConduitWorkflow.php

src/workflow/ArcanistCloseRevisionWorkflow.php

src/workflow/ArcanistCloseWorkflow.php

src/workflow/ArcanistCommitWorkflow.php

src/workflow/ArcanistCoverWorkflow.php

src/workflow/ArcanistDiffWorkflow.php

src/workflow/ArcanistDownloadWorkflow.php

src/workflow/ArcanistExportWorkflow.php

src/workflow/ArcanistFeatureWorkflow.php

src/workflow/ArcanistFlagWorkflow.php

src/workflow/ArcanistGitHookPreReceiveWorkflow.php

src/workflow/ArcanistHelpWorkflow.php

src/workflow/ArcanistInlinesWorkflow.php

src/workflow/ArcanistInstallCertificateWorkflow.php

src/workflow/ArcanistLandWorkflow.php

src/workflow/ArcanistLiberateWorkflow.php

src/workflow/ArcanistLintWorkflow.php

src/workflow/ArcanistListWorkflow.php

src/workflow/ArcanistPasteWorkflow.php

src/workflow/ArcanistPatchWorkflow.php

src/workflow/ArcanistRevertWorkflow.php

src/workflow/ArcanistSetConfigWorkflow.php

src/workflow/ArcanistShellCompleteWorkflow.php

src/workflow/ArcanistSvnHookPreCommitWorkflow.php

src/workflow/ArcanistTasksWorkflow.php

src/workflow/ArcanistTodoWorkflow.php

src/workflow/ArcanistUnitWorkflow.php

src/workflow/ArcanistUpgradeWorkflow.php

src/workflow/ArcanistUploadWorkflow.php

src/workflow/ArcanistWhichWorkflow.php

src/workingcopyidentity/ArcanistWorkingCopyIdentity.php