Page MenuHomePhabricator

Various minor improvements to the `xsprintf` functions
ClosedPublic

Authored by joshuaspence on Jun 30 2014, 10:19 PM.
Tags
None
Referenced Files
F14057229: D9788.diff
Sun, Nov 17, 1:31 AM
F13974933: D9788.id23499.diff
Oct 18 2024, 7:58 AM
F13974011: D9788.diff
Oct 18 2024, 3:39 AM
F13968757: D9788.id23499.diff
Oct 16 2024, 10:58 PM
F13968756: D9788.id23495.diff
Oct 16 2024, 10:58 PM
F13968755: D9788.id.diff
Oct 16 2024, 10:58 PM
F13968754: D9788.diff
Oct 16 2024, 10:57 PM
Unknown Object (File)
Oct 12 2024, 11:52 AM
Subscribers

Details

Summary
  • Renamed Phutil*sprintfTestCase classes to use proper camel case.
  • Added some type hints for function parameters, where appropriate.
  • Use more specific (SPL) Exception types, where appropriate.
  • Change ## to \` in comments.
  • Wrap functions in @{function:...} when they appear in comments.
Test Plan

arc unit still works.

Diff Detail

Repository
rPHU libphutil
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

joshuaspence retitled this revision from to Various minor improvements to the `xsprintf` functions.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
epriestley edited edge metadata.
This revision is now accepted and ready to land.Jul 1 2014, 1:19 PM