Page MenuHomePhabricator

Various minor improvements to the `xsprintf` functions
ClosedPublic

Authored by joshuaspence on Jun 30 2014, 10:19 PM.
Tags
None
Referenced Files
F18743920: D9788.id.diff
Fri, Oct 3, 1:19 AM
F18722905: D9788.id23499.diff
Mon, Sep 29, 11:36 PM
F18716117: D9788.diff
Mon, Sep 29, 11:30 AM
F18657228: D9788.diff
Tue, Sep 23, 12:59 AM
F18597821: D9788.id23495.diff
Sep 13 2025, 3:45 AM
F18593148: D9788.id23495.diff
Sep 12 2025, 2:03 PM
F18590617: D9788.diff
Sep 12 2025, 6:34 AM
F18557965: D9788.id.diff
Sep 8 2025, 8:13 PM
Subscribers

Details

Summary
  • Renamed Phutil*sprintfTestCase classes to use proper camel case.
  • Added some type hints for function parameters, where appropriate.
  • Use more specific (SPL) Exception types, where appropriate.
  • Change ## to \` in comments.
  • Wrap functions in @{function:...} when they appear in comments.
Test Plan

arc unit still works.

Diff Detail

Repository
rPHU libphutil
Branch
xsprintf
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 1473
Build 1473: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence retitled this revision from to Various minor improvements to the `xsprintf` functions.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
epriestley edited edge metadata.
This revision is now accepted and ready to land.Jul 1 2014, 1:19 PM