Paths

Table of Contentst

Ignore `#hashtag` implicit project tags which have no effect
ClosedPublic
Actions

Authored by epriestley on Jun 26 2014, 9:02 PM.

Details

Reviewers

joshuaspence
chad

Maniphest Tasks

T5489: "Action With No Effect" warning when commenting on a differential

Commits

Restricted Diffusion Commit
rPf96767823677: Ignore `#hashtag` implicit project tags which have no effect

Summary

Fixes T5489. Currently, if you make a #proj comment on an object already tagged with #proj, you get a "no effect" dialog.

Instead, continue if these transactions produce no effect (this is normal/expected, and consistent with @user).

Test Plan

Made two #proj comments in a row on a revision.

Diff Detail

Repository

rP Phabricator

Branch

noeffect

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 1416
Build 1416: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 23403.Jun 26 2014, 9:02 PM

epriestley retitled this revision from to Ignore `#hashtag` implicit project tags which have no effect.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added reviewers: joshuaspence, chad.

epriestley added a task: T5489: "Action With No Effect" warning when commenting on a differential.

Herald added a subscriber: epriestley. · View Herald TranscriptJun 26 2014, 9:02 PM

chad accepted this revision.Jun 26 2014, 9:03 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Jun 26 2014, 9:03 PM

Harbormaster completed remote builds in B1416: Diff 23403.Jun 26 2014, 9:03 PM

Closed by commit rPf96767823677 (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

applications/

transactions/

editor/

PhabricatorApplicationTransactionEditor.php

1 line

Diff 23403

View Options

src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php

Ignore `#hashtag` implicit project tags which have no effectClosedPublicActions