Improve the handling of the `php_compat_info.json` file.
ClosedPublic
Actions

Authored by joshuaspence on Jun 22 2014, 4:54 AM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Commits

rARC990027e3e04c: Improve the handling of the `php_compat_info.json` file.

Summary

See inline comments on D9576. Also replace json_decode with phutil_json_decode, for better error handling.

Test Plan

Make sure arc unit still works.

Diff Detail

Repository

rARC Arcanist

Branch

xhpast-readfile

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 1286
Build 1286: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence updated this revision to Diff 23171.Jun 22 2014, 4:54 AM

joshuaspence retitled this revision from to Improve the handling of the `php_compat_info.json` file..

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJun 22 2014, 4:54 AM

Herald added subscribers: Korvin, epriestley. · View Herald Transcript

Harbormaster completed remote builds in B1286: Diff 23171.Jun 22 2014, 4:55 AM

epriestley accepted this revision.Jun 22 2014, 3:10 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Jun 22 2014, 3:10 PM

Closed by commit rARC990027e3e04c (authored by @joshuaspence).

Revision Contents
Changeset List

Path

Size

src/

lint/

linter/

ArcanistXHPASTLinter.php

2 lines

Diff 23171

View Options

src/lint/linter/ArcanistXHPASTLinter.php

Improve the handling of the `php_compat_info.json` file.ClosedPublicActions