Fixes T5385. Provide a flexible means of setting a minimum PHP version for the ArcanistXHPASTLinter, instead of relying on ArcanistXHPASTLinter::LINT_PHP_53_FEATURES and ArcanistXHPASTLinter::LINT_PHP_54_FEATURES.
- Group Reviewers
- Maniphest Tasks
- T5385: Allow PHP version to be customized with `ArcanistXHPASTLinter`
- rARC4c99a6556778: Allow PHP version to be customized with `ArcanistXHPASTLinter`
Fixed up and ran unit tests.
Should maybe attempt to validate if $value looks like a valid PHP version.
Should probably look at whether LINT_PHP_53_FEATURES and/or LINT_PHP_54_FEATURES are being used (i.e. is a non-disabled severity set) and then:
This is probably wrong now and needs to be given some more thought.