Page MenuHomePhabricator

Don't throw an exception if no configuration is set for linter tests
ClosedPublic

Authored by joshuaspence on Jun 20 2014, 9:06 PM.
Tags
None
Referenced Files
F14035175: D9643.diff
Sun, Nov 10, 4:38 AM
F14007616: D9643.diff
Tue, Oct 29, 8:59 AM
F13985257: D9643.id23145.diff
Sun, Oct 20, 7:11 PM
F13983911: D9643.diff
Sun, Oct 20, 9:37 AM
Unknown Object (File)
Oct 13 2024, 5:05 AM
Unknown Object (File)
Oct 10 2024, 5:39 PM
Unknown Object (File)
Oct 9 2024, 1:54 PM
Unknown Object (File)
Oct 7 2024, 3:25 AM
Subscribers

Details

Summary

This was broken in D9641. If $config is not set, then a PhutilJSONParserException will be thrown. The expected behaviour is that it is okay to not explicitly set any configuration.

Test Plan

Ran arc unit.

Diff Detail

Repository
rARC Arcanist
Branch
fixjson
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 1268
Build 1268: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence retitled this revision from to Don't throw an exception if no configuration is set for linter tests.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
epriestley edited edge metadata.
This revision is now accepted and ready to land.Jun 20 2014, 9:09 PM