Paths

Table of Contentst

Don't throw an exception if no configuration is set for linter tests
ClosedPublic
Actions

Authored by joshuaspence on Jun 20 2014, 9:06 PM.

Tags

None

Referenced Files

	F14389011: D9643.id23147.diff
	Sat, Dec 21, 5:16 PM

	Unknown Object (File)
	Sun, Dec 15, 10:42 AM

	Unknown Object (File)
	Sat, Dec 14, 4:34 PM

	Unknown Object (File)
	Fri, Dec 13, 11:43 AM

	Unknown Object (File)
	Fri, Dec 13, 3:19 AM

	Unknown Object (File)
	Fri, Dec 13, 2:01 AM

	Unknown Object (File)
	Thu, Dec 12, 5:51 PM

	Unknown Object (File)
	Wed, Dec 11, 2:17 AM

View All Files

Subscribers

epriestley

Korvin

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Commits

rARCa428f22cbf07: Don't throw an exception if no configuration is set for linter tests

Summary

This was broken in D9641. If $config is not set, then a PhutilJSONParserException will be thrown. The expected behaviour is that it is okay to not explicitly set any configuration.

Test Plan

Ran arc unit.

Diff Detail

Repository

rARC Arcanist

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

joshuaspence updated this revision to Diff 23145.Jun 20 2014, 9:06 PM

joshuaspence retitled this revision from to Don't throw an exception if no configuration is set for linter tests.

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJun 20 2014, 9:06 PM

Herald added subscribers: Korvin, epriestley. · View Herald Transcript

Harbormaster completed remote builds in B1268: Diff 23145.Jun 20 2014, 9:07 PM

epriestley accepted this revision.Jun 20 2014, 9:09 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Jun 20 2014, 9:09 PM

Closed by commit rARCa428f22cbf07 (authored by @joshuaspence).

Revision Contents
Changeset List

Path

Size

src/

lint/

linter/

__tests__/

ArcanistLinterTestCase.php

6 lines

Diff 23147

View Options

src/lint/linter/tests/ArcanistLinterTestCase.php

Don't throw an exception if no configuration is set for linter testsClosedPublicActions