Differential D9579

Disable full screen mode for inline comments
ClosedPublic
Actions

Authored by garoevans on Jun 16 2014, 7:50 PM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Maniphest Tasks

T5272: Fullscreen mode on inline comments is janked up

Commits

Restricted Diffusion Commit
rPbaa998faa41a: Disable full screen mode for inline comments

Summary

Full screen is a little foobar so disabling it for inline comments
Fixes T5272

Test Plan

View inline comment after change, make sure full screen option
has gone.

Diff Detail

Repository

rP Phabricator

Branch

T5272

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 1149
Build 1149: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

garoevans updated this revision to Diff 22956.Jun 16 2014, 7:50 PM

garoevans added a task: T5272: Fullscreen mode on inline comments is janked up.

garoevans retitled this revision from to Disable full screen mode for inline comments.

garoevans updated this object.

garoevans edited the test plan for this revision. (Show Details)

garoevans added a reviewer: epriestley.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJun 16 2014, 7:50 PM

Herald added subscribers: Korvin, epriestley. · View Herald Transcript

Harbormaster completed remote builds in B1149: Diff 22956.Jun 16 2014, 7:51 PM

epriestley accepted this revision.Jun 16 2014, 8:00 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Jun 16 2014, 8:00 PM

Closed by commit rPbaa998faa41a (authored by @garoevans, committed by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

infrastructure/

diff/

PhabricatorInlineCommentController.php

3 lines

view/

form/

control/

PhabricatorRemarkupControl.php

25 lines

Diff 22956

View Options

src/infrastructure/diff/PhabricatorInlineCommentController.php