Page MenuHomePhabricator
Create Task
Maniphest T5272

Fullscreen mode on inline comments is janked up
Closed, ResolvedPublic
Actions

Description

Might be easiest to just remove the mode. Repro:

  • Start an inline comment.
  • Click fullscreen mode.
  • get a glitchy mess

Revisions and Commits

rP Phabricator
D9579rPbaa998faa41a Disable full screen mode for inline comments

Event Timeline

epriestley created this task.Jun 5 2014, 8:47 PM
epriestley raised the priority of this task from to Normal.
epriestley updated the task description. (Show Details)
epriestley added subscribers: epriestley, staticshock.
epriestley added a project: Badge Awarded.Jun 16 2014, 6:57 PM

I think the easiest fix here is just to not offer the fullscreen action on inlines. We could try to make it work eventually, but just removing it seems reasonable and is much easier.

garoevans edited this Maniphest Task.Jun 16 2014, 7:50 PM
chad added a subscriber: chad.Jun 16 2014, 7:54 PM

Random question, is the Remarkup bar required for Remarkup text areas, or just there for consistency?

epriestley added a comment.Jun 16 2014, 8:04 PM

It's just there for consistency, and as a hint that something is remarkup instead of plain text.

garoevans edited this Maniphest Task.Jun 16 2014, 8:05 PM
garoevans closed this task as Resolved.Jun 16 2014, 8:05 PM

Closed by commit rPbaa998faa41a.

Phabricator · Built by Phacility