Page MenuHomePhabricator

Add support for playing sounds
ClosedPublic

Authored by epriestley on Jun 14 2014, 9:40 PM.
Tags
None
Referenced Files
F12843355: D9535.id28968.diff
Thu, Mar 28, 10:42 PM
Unknown Object (File)
Feb 1 2024, 5:06 PM
Unknown Object (File)
Jan 26 2024, 10:03 PM
Unknown Object (File)
Jan 26 2024, 7:00 AM
Unknown Object (File)
Jan 6 2024, 8:21 PM
Unknown Object (File)
Dec 23 2023, 4:37 AM
Unknown Object (File)
Dec 20 2023, 7:08 AM
Unknown Object (File)
Dec 15 2023, 9:33 AM

Details

Summary

Ref T5369. New HTML5 version without flash dependencies.

This doesn't play any sounds.

Test Plan

Did not play any sounds.

Diff Detail

Repository
rP Phabricator
Branch
sound3
Lint
Lint Warnings
SeverityLocationCodeMessage
Warningwebroot/rsrc/externals/javelin/lib/Sound.js:1JAVELIN5`javelinsymbols` Not In Path
Unit
Tests Passed
Build Status
Buildable 4830
Build 4846: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

  • No Flash dependency.
  • Seems fine in Safari, Chrome, Firefox.
  • But plays multiple times with multiple open tabs, since there's no synchronization.

We can't move this forward until synchronization works.

epriestley retitled this revision from [Draft] Play sounds to Play sounds when chat is received.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
  • New version which seems reasonable enough to move forward with.

I don't like the sound. It reminds me of speakers cracking from some bad signal.

I'd like a sound that is either more of a chime (reverberating metal / other material that is pleasant in tone) or more "wet" (so more of a popping bubble) or maybe we can have it all and get some sort of chiming bubble pop sound.

epriestley edited edge metadata.
  • Add sound tech but no actual sounds.
epriestley retitled this revision from Play sounds when chat is received to Add support for playing sounds.Mar 10 2015, 8:39 PM
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
btrahan edited edge metadata.
This revision is now accepted and ready to land.Mar 10 2015, 8:55 PM
This revision was automatically updated to reflect the committed changes.