Page MenuHomePhabricator

Update `.gitignore`.
ClosedPublic

Authored by joshuaspence on Jun 14 2014, 6:18 PM.
Tags
None
Referenced Files
F14027624: D9527.diff
Fri, Nov 8, 8:14 AM
F14024722: D9527.diff
Thu, Nov 7, 11:46 AM
F14024498: D9527.id22844.diff
Thu, Nov 7, 9:54 AM
F14024404: D9527.id22841.diff
Thu, Nov 7, 9:09 AM
F14024382: D9527.id22834.diff
Thu, Nov 7, 8:49 AM
F14017641: D9527.diff
Mon, Nov 4, 8:31 PM
F14008180: D9527.diff
Tue, Oct 29, 5:05 PM
F13966515: D9527.id.diff
Wed, Oct 16, 8:20 AM
Subscribers

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Commits
Restricted Diffusion Commit
rPadbdea8d3f90: Update `.gitignore`.
Summary

See inline comments for reasoning.

Test Plan

N/A

Diff Detail

Repository
rP Phabricator
Branch
gitignore
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 1079
Build 1079: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence retitled this revision from to Update `.gitignore`..
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
.gitignore
1–12

These files are specific to the developer's environment. They should be include in the developer's local gitignore.

14–15

I don't think that this exists anymore.

joshuaspence edited edge metadata.

/.divinercache is a directory.

epriestley edited edge metadata.
  • In theory, you are completely correct.
  • In practice, we get pull requests if we don't put this stuff in .gitignore. This didn't seem like the most important battle to fight after a couple of them.

I'll accept this if you put a message in its place, like:

# NOTE: Thinking about adding files created by your operating system, IDE,
# or text editor here? Don't! Add them to your per-user .gitignore instead.

..and we can see how that goes?

This revision now requires changes to proceed.Jun 14 2014, 6:36 PM
joshuaspence edited edge metadata.
  • Adding a comment as requested.
epriestley edited edge metadata.
This revision is now accepted and ready to land.Jun 14 2014, 6:44 PM
epriestley updated this revision to Diff 22844.

Closed by commit rPadbdea8d3f90 (authored by @joshuaspence, committed by @epriestley).