Paths

Table of Contentst

Differential D9527

Update `.gitignore`.
ClosedPublic
Actions

Authored by joshuaspence on Jun 14 2014, 6:18 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Fri, Aug 9, 7:19 PM

	Unknown Object (File)
	Tue, Aug 6, 8:42 AM

	Unknown Object (File)
	Fri, Aug 2, 9:47 AM

	Unknown Object (File)
	Tue, Jul 30, 6:12 PM

	Unknown Object (File)
	Mon, Jul 29, 7:39 AM

	Unknown Object (File)
	Sat, Jul 27, 6:19 AM

	Unknown Object (File)
	Mon, Jul 22, 11:48 PM

	Unknown Object (File)
	Thu, Jul 18, 11:57 PM

Subscribers

Details

Reviewers

Group Reviewers

Blessed Reviewers

Commits

Restricted Diffusion Commit
rPadbdea8d3f90: Update `.gitignore`.

Summary

See inline comments for reasoning.

Test Plan

N/A

Diff Detail

Repository

Branch

gitignore

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 1078
Build 1078: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence updated this revision to Diff 22834.Jun 14 2014, 6:18 PM

joshuaspence retitled this revision from to Update `.gitignore`..

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJun 14 2014, 6:18 PM

Herald added subscribers: Korvin, epriestley. · View Herald Transcript

Harbormaster completed remote builds in B1078: Diff 22834.Jun 14 2014, 6:19 PM

joshuaspence added inline comments.Jun 14 2014, 6:20 PM

.gitignore
1–12	These files are specific to the developer's environment. They should be include in the developer's local `gitignore`.
14–15	I don't think that this exists anymore.

/.divinercache is a directory.

Harbormaster completed remote builds in B1079: Diff 22835.Jun 14 2014, 6:22 PM

In theory, you are completely correct.
In practice, we get pull requests if we don't put this stuff in .gitignore. This didn't seem like the most important battle to fight after a couple of them.

I'll accept this if you put a message in its place, like:

# NOTE: Thinking about adding files created by your operating system, IDE,
# or text editor here? Don't! Add them to your per-user .gitignore instead.

..and we can see how that goes?

This revision now requires changes to proceed.Jun 14 2014, 6:36 PM

Adding a comment as requested.

Harbormaster completed remote builds in B1084: Diff 22841.Jun 14 2014, 6:42 PM

epriestley accepted this revision.Jun 14 2014, 6:44 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Jun 14 2014, 6:44 PM

Closed by commit rPadbdea8d3f90 (authored by @joshuaspence, committed by @epriestley).

Revision Contents
Changeset List

Path

Size

16 lines

Diff 22834

.gitignore

Loading...