Currently, 'foo'. // Some comment is not allowed by the ArcanistXHPASTLinter::LINT_BINARY_EXPRESSION_SPACING rule. I believe that in the case of a trailing comment, we should allow whitespace after the . operator.
Details
Details
- Reviewers
epriestley - Group Reviewers
Blessed Reviewers - Commits
- rARC57f4bbae42c5: Allow spaces after the `.` operator if followed by a comment.
Wrote and executed a unit test for this case.
Diff Detail
Diff Detail
- Repository
- rARC Arcanist
- Branch
- dotspace
- Lint
Lint Passed - Unit
Tests Passed - Build Status
Buildable 940 Build 940: [Placeholder Plan] Wait for 30 Seconds
Event Timeline
Comment Actions
Closed by commit rARC57f4bbae42c5 (authored by @joshuaspence, committed by @epriestley).
Comment Actions
Spot on, this is from src/markup/engine/remarkup/blockrule/PhutilRemarkupEngineRemarkupSimpleTableBlockRule.php (rPHU):
preg_match_all( '/\|'. '('. '(?:'. '(?:\\[\\[.*?\\]\\])'. // [[ ... | ... ]], a link '|'. '(?:[^|[]+)'. // Anything but "|" or "[". '|'. '(?:\\[[^\\|[])'. // "[" followed by anything but "[" or "|" ')*'. ')/', $line, $matches);