Paths

Table of Contentst

Fix "array to string" conversion error.
ClosedPublic
Actions

Authored by joshuaspence on Jun 9 2014, 6:26 PM.

Tags

None

Referenced Files

	F15457639: D9434.diff
	Sun, Mar 30, 5:30 PM

	F15452326: D9434.id22521.diff
	Sat, Mar 29, 3:48 AM

	F15452325: D9434.id22520.diff
	Sat, Mar 29, 3:48 AM

	F15452324: D9434.id.diff
	Sat, Mar 29, 3:48 AM

	F15452222: D9434.diff
	Sat, Mar 29, 3:09 AM

	F15432811: D9434.diff
	Mon, Mar 24, 7:42 PM

	F15389578: D9434.id22520.diff
	Sat, Mar 15, 5:28 AM

	F15385708: D9434.id.diff
	Fri, Mar 14, 11:13 PM

View All Files

Subscribers

epriestley

Korvin

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Maniphest Tasks

T5298: "Array to string conversion" error

Commits

rARC86eec5b44c71: Fix "array to string" conversion error.

Summary

Fixes T5298. This bug was probably introduced in D9248. It looks like I forgot to update some references to $version.

Test Plan

Ran arc lint --everything in rPHU.

Diff Detail

Repository

rARC Arcanist

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

joshuaspence updated this revision to Diff 22520.Jun 9 2014, 6:26 PM

joshuaspence retitled this revision from to Fix "array to string" conversion error..

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

joshuaspence added a task: T5298: "Array to string conversion" error.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJun 9 2014, 6:26 PM

Herald added subscribers: Korvin, epriestley. · View Herald Transcript

Harbormaster completed remote builds in B936: Diff 22520.Jun 9 2014, 6:28 PM

epriestley accepted this revision.Jun 9 2014, 6:32 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Jun 9 2014, 6:32 PM

Closed by commit rARC86eec5b44c71 (authored by @joshuaspence, committed by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

lint/

linter/

ArcanistXHPASTLinter.php

4 lines

Diff 22521

View Options

src/lint/linter/ArcanistXHPASTLinter.php

Fix "array to string" conversion error.ClosedPublicActions