Page MenuHomePhabricator
Differential D9415

Only send Aphlict notifications to subscribed users.
AbandonedPublic
Actions

Authored by joshuaspence on Jun 6 2014, 11:13 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Jan 22, 10:23 AM
Unknown Object (File)
Dec 17 2024, 4:16 PM
Unknown Object (File)
Dec 3 2024, 4:44 AM
Unknown Object (File)
Sep 14 2024, 3:19 AM
Unknown Object (File)
Sep 3 2024, 4:27 PM
Unknown Object (File)
Aug 25 2024, 3:23 AM
Unknown Object (File)
Aug 20 2024, 5:37 AM
Unknown Object (File)
May 17 2024, 3:10 AM
View All 37 Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T4324: Change notification server so it only alerts appropriate clients
Summary

Fixes T4324. Only broadcast Aphlict notifications to users who are subscribed to receive the notification. I guess that "broadcast" isn't really the right word anymore, but oh well.

Depends on D9400.

Test Plan

Coming right up.

Diff Detail

Repository
rP Phabricator
Branch
aphlict-subscribe
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 911
Build 911: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence updated this revision to Diff 22467.Jun 6 2014, 11:13 PM
joshuaspence retitled this revision from to Only send Aphlict notifications to subscribed users..
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
joshuaspence added a task: T4324: Change notification server so it only alerts appropriate clients.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJun 6 2014, 11:13 PM
Herald added subscribers: Korvin, epriestley. · View Herald Transcript
joshuaspence updated this object.Jun 6 2014, 11:14 PM
joshuaspence edited edge metadata.
joshuaspence added a parent revision: D9400: Allow Aphlict clients to register their user PHID with the Aphlict server..
Harbormaster completed remote builds in B910: Diff 22467.Jun 6 2014, 11:14 PM
joshuaspence updated this revision to Diff 22468.Jun 6 2014, 11:18 PM
  • Create a unique AphlictMaster for a given user.
Harbormaster completed remote builds in B911: Diff 22468.Jun 6 2014, 11:19 PM
joshuaspence planned changes to this revision.Jun 7 2014, 6:34 PM

This isn't quite working yet.

joshuaspence abandoned this revision.Jun 10 2014, 7:17 PM

This will be basically redone.

Revision Contents
Changeset List

PathSize
src/
applications/
notification/
client/
2 lines
support/
aphlict/
client/
src/
2 lines
server/
22 lines
webroot/
rsrc/
swf/

Diff 22468

View Options

src/applications/notification/client/PhabricatorNotificationClient.php

Loading...
View Options

support/aphlict/client/src/AphlictMaster.as

Loading...
View Options

support/aphlict/server/aphlict_server.js

Loading...
View Options

webroot/rsrc/swf/aphlict.swf

Loading...
Phabricator · Built by Phacility