Paths

Table of Contentst

Differential D9415

Only send Aphlict notifications to subscribed users.
AbandonedPublic
Actions

Authored by joshuaspence on Jun 6 2014, 11:13 PM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Maniphest Tasks

T4324: Change notification server so it only alerts appropriate clients

Summary

Fixes T4324. Only broadcast Aphlict notifications to users who are subscribed to receive the notification. I guess that "broadcast" isn't really the right word anymore, but oh well.

Depends on D9400.

Test Plan

Coming right up.

Diff Detail

Repository

rP Phabricator

Branch

aphlict-subscribe

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 910
Build 910: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence updated this revision to Diff 22467.Jun 6 2014, 11:13 PM

joshuaspence retitled this revision from to Only send Aphlict notifications to subscribed users..

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

joshuaspence added a task: T4324: Change notification server so it only alerts appropriate clients.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJun 6 2014, 11:13 PM

Herald added subscribers: Korvin, epriestley. · View Herald Transcript

joshuaspence updated this object.Jun 6 2014, 11:14 PM

joshuaspence edited edge metadata.

joshuaspence added a parent revision: D9400: Allow Aphlict clients to register their user PHID with the Aphlict server..

Harbormaster completed remote builds in B910: Diff 22467.Jun 6 2014, 11:14 PM

Create a unique AphlictMaster for a given user.

Harbormaster completed remote builds in B911: Diff 22468.Jun 6 2014, 11:19 PM

This isn't quite working yet.

This will be basically redone.

Revision Contents
Changeset List

Path

Size

src/

applications/

notification/

client/

PhabricatorNotificationClient.php

2 lines

support/

aphlict/

server/

aphlict_server.js

22 lines

Diff 22467

View Options

src/applications/notification/client/PhabricatorNotificationClient.php