Page MenuHomePhabricator
Differential D9380

Catch errors that may occur whilst receiving data from the Aphlict server.
ClosedPublic
Actions

Authored by joshuaspence on Jun 4 2014, 11:28 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Dec 13, 10:14 PM
Unknown Object (File)
Wed, Dec 11, 7:26 AM
Unknown Object (File)
Mon, Dec 9, 11:03 AM
Unknown Object (File)
Thu, Dec 5, 5:15 AM
Unknown Object (File)
Sat, Nov 30, 6:00 PM
Unknown Object (File)
Wed, Nov 27, 9:54 AM
Unknown Object (File)
Fri, Nov 22, 11:46 PM
Unknown Object (File)
Fri, Nov 22, 5:36 PM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T4324: Change notification server so it only alerts appropriate clients
Commits
Restricted Diffusion Commit
rP8033a697461d: Catch errors that may occur whilst receiving data from the Aphlict server.
Summary

Ref T4324. Currently, if the AphlictMaster receives dodgy data from the Aphlict server (invalid JSON, for example) then a syntax error will be thrown and the AphlictMaster will die. Instead, catch errors and raise a notification.

Test Plan

error.png (649×1 px, 39 KB)

Diff Detail

Repository
rP Phabricator
Branch
aphlict-error
Lint
Lint Warnings
SeverityLocationCodeMessage
Warningwebroot/rsrc/js/application/aphlict/behavior-aphlict-listen.js:36TXT3Line Too Long
Unit
No Test Coverage
Build Status
Buildable 858
Build 858: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence updated this revision to Diff 22363.Jun 4 2014, 11:28 PM
joshuaspence retitled this revision from to Catch errors that may occur whilst receiving data from the Aphlict server..
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
joshuaspence added a task: T4324: Change notification server so it only alerts appropriate clients.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJun 4 2014, 11:28 PM
Herald added subscribers: Korvin, epriestley. · View Herald Transcript
Harbormaster completed remote builds in B855: Diff 22363.Jun 4 2014, 11:29 PM
joshuaspence updated this revision to Diff 22365.Jun 5 2014, 2:04 AM
joshuaspence edited edge metadata.

Always show Aphlict errors as a notification popup (even when debug mode is disabled).

Harbormaster completed remote builds in B857: Diff 22365.Jun 5 2014, 2:05 AM
joshuaspence updated this revision to Diff 22368.Jun 5 2014, 2:15 AM

Recompile.

Harbormaster completed remote builds in B858: Diff 22368.Jun 5 2014, 2:17 AM
joshuaspence edited the test plan for this revision. (Show Details)Jun 5 2014, 2:35 AM
joshuaspence updated this revision to Diff 22371.Jun 5 2014, 2:37 AM
joshuaspence edited the test plan for this revision. (Show Details)

Fix line length.

Harbormaster completed remote builds in B859: Diff 22371.Jun 5 2014, 2:39 AM
joshuaspence updated this revision to Diff 22372.Jun 5 2014, 2:39 AM

Prefix error message with "(Aphlict) "

Harbormaster completed remote builds in B860: Diff 22372.Jun 5 2014, 2:40 AM
joshuaspence updated this object.Jun 5 2014, 7:06 AM
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence updated this object.Jun 5 2014, 7:09 AM
epriestley accepted this revision.Jun 5 2014, 4:41 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Jun 5 2014, 4:41 PM
epriestley closed this revision.Jun 5 2014, 4:43 PM
epriestley updated this revision to Diff 22394.

Closed by commit rP8033a697461d (authored by @joshuaspence, committed by @epriestley).

Revision Contents
Changeset List

PathSize
support/
aphlict/
client/
src/
4 lines
52 lines
webroot/
rsrc/
js/
application/
aphlict/
45 lines
swf/

Diff 22368

View Options

support/aphlict/client/src/Aphlict.as

Loading...
View Options

support/aphlict/client/src/AphlictMaster.as

Loading...
View Options

webroot/rsrc/js/application/aphlict/behavior-aphlict-listen.js

Loading...
View Options

webroot/rsrc/swf/aphlict.swf

Loading...
Phabricator · Built by Phacility