Page MenuHomePhabricator

Style Aphlict security error notifications appropriately.
AbandonedPublic

Authored by joshuaspence on Jun 5 2014, 3:10 AM.

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Summary

Currently, although there exists a jx-notification-security CSS class, security errors from the Aphlict client are displayed identically to any other kind of error notification. We should probably display these differently since they represent a different kind of issue than a general error.

Depends on D9380.

Test Plan

I haven't tested this because I am not sure how to generate a security error.

Diff Detail

Repository
rP Phabricator
Branch
aphlict-security
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 863
Build 863: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence retitled this revision from to Special case Aphlict security errors..
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
joshuaspence retitled this revision from Special case Aphlict security errors. to Style Aphlict security error notifications appropriately..Jun 5 2014, 7:10 AM
joshuaspence updated this object.

Maybe we should just remove the CSS class if we can't figure out how to generate a security error? I don't know either. Offhand, this class of errors doesn't necessarily seem much different from "error" errors to me?

Actually, the CSS class is also used in webroot/rsrc/js/core/behavior-high-security-warning.js. Let me try to see under what circumstances a security error is raised in ActionScript.

Oh, right. We probably shouldn't use the same color, those messages do have significantly different implications ("security" is "your account is in high security mode, click to return to normal mode").

Ok, let's just leave this as is then.