Differential D9315

Improve performance of lint differencing query
AbandonedPublic
Actions

Authored by hach-que on May 28 2014, 1:22 AM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Summary

Depends on D9233.

This substantially improves the performance of displaying lint trends in Diffusion (from 300 second query to a 5 second query).

Test Plan

Last modified information didn't take 5 minutes to load. Compared using DarkConsole.

Diff Detail

Repository

rP Phabricator

Branch

lint-fast

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 732
Build 732: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

hach-que updated this revision to Diff 22101.May 28 2014, 1:22 AM

hach-que retitled this revision from to Improve performance of lint differencing query.

hach-que updated this object.

hach-que edited the test plan for this revision. (Show Details)

hach-que added a reviewer: epriestley.

hach-que added a parent revision: D9233: Show lint trend information in Diffusion from Fact.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptMay 28 2014, 1:22 AM

Herald added subscribers: Korvin, epriestley. · View Herald Transcript

Harbormaster completed remote builds in B731: Diff 22101.May 28 2014, 1:23 AM

Ignore this for now.

hach-que planned changes to this revision.May 28 2014, 1:27 AM

Actually make the query work. Also exclude valueX where it's 0 (no change), since we want to see changes the impact the lint values.

Harbormaster completed remote builds in B732: Diff 22102.May 28 2014, 2:03 AM

Abandoning because Fact is very far away on the roadmap.

Revision Contents
Changeset List

Path

Size

src/

applications/

diffusion/

fact/

PhabricatorFactLintEngine.php

29 lines

Diff 22102

View Options

src/applications/diffusion/fact/PhabricatorFactLintEngine.php

Improve performance of lint differencing queryAbandonedPublicActions