Differential D9234

Update unique key for Fact aggregates to include a hash of stringA
AbandonedPublic
Actions

Authored by hach-que on May 21 2014, 6:44 AM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Summary

Depends on D9130.

Without this unique key it's impossible to publish aggregate information for the same object with different stringA values. This fixes the lint engine because it relied on the previous aggregation value to determine the difference and because the aggregated data for multiple paths wasn't recorded correctly, it would always detect the previous value as 0.

Test Plan

Ran the Fact analysis and saw multiple aggregate records for different paths.

Diff Detail

Repository

rP Phabricator

Branch

live-master

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 2715
Build 2719: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

hach-que updated this revision to Diff 21928.May 21 2014, 6:44 AM

hach-que retitled this revision from to Update unique key for Fact aggregates to include a hash of stringA.

hach-que updated this object.

hach-que edited the test plan for this revision. (Show Details)

hach-que added a reviewer: epriestley.

hach-que added a parent revision: D9130: Publish branch lint information into Fact.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptMay 21 2014, 6:44 AM

Herald added subscribers: Korvin, epriestley. · View Herald Transcript

Harbormaster completed remote builds in B622: Diff 21928.May 21 2014, 6:45 AM

Fixing line length

Harbormaster completed remote builds in B623: Diff 21929.May 21 2014, 6:47 AM

Abandoning this because Fact is still very far away on the upstream roadmap, and by the time upstream work starts on it, this will probably be out-of-date anyway.

hach-que abandoned this revision.Jul 31 2014, 11:38 AM