Page MenuHomePhabricator
Differential D9291

Add a `bin/hunks` script to manage migrations of hunk data
ClosedPublic
Actions

Authored by epriestley on May 25 2014, 5:02 PM.
Tags
None
Referenced Files
F17989796: D9291.id22058.diff
Sat, Aug 2, 12:15 AM
F17946778: D9291.id.diff
Thu, Jul 31, 3:07 PM
F17946601: D9291.id22330.diff
Thu, Jul 31, 2:43 PM
F17922361: D9291.diff
Wed, Jul 30, 6:41 AM
F17837325: D9291.id22330.diff
Sat, Jul 26, 5:12 PM
F17808600: D9291.id22058.diff
Fri, Jul 25, 4:06 PM
Unknown Object (File)
Jun 29 2025, 3:04 PM
Unknown Object (File)
Jun 29 2025, 1:57 PM
View All Files
Subscribers
epriestley

Details

Reviewers
btrahan
Maniphest Tasks
T4045: Store diffs as binary, not UTF-8
T5179: Unearth Differential rendering technical debt
Commits
Restricted Diffusion Commit
rP5b1262c98b8f: Add a `bin/hunks` script to manage migrations of hunk data
Summary

Ref T4045. Ref T5179. While we'll eventually need to force a migration, we can let installs (particularly large installs) do an online migration for now. This moves hunks to the new storage format one at a time.

(Note that nothing writes to the new store yet, so this is the only way to populate it.)

WARNING: Installs, don't run this yet! It won't compress the data. Wait until it can also do compression.
Test Plan

Added a break; after migrating one row and moved a few rows over. Spot checked them in the database and viewed the affected diffs.

Diff Detail

Repository
rP Phabricator
Branch
hunk6
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 701
Build 701: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 22058.May 25 2014, 5:02 PM
epriestley retitled this revision from to Add a `bin/hunks` script to manage migrations of hunk data.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley added tasks: T5179: Unearth Differential rendering technical debt, T4045: Store diffs as binary, not UTF-8.
Herald added a subscriber: epriestley. · View Herald TranscriptMay 25 2014, 5:02 PM
Harbormaster completed remote builds in B701: Diff 22058.May 25 2014, 5:04 PM
btrahan accepted this revision.Jun 3 2014, 10:11 PM
btrahan edited edge metadata.
btrahan added inline comments.
src/applications/differential/management/PhabricatorHunksManagementMigrateWorkflow.php
10

if the NOTE to installs is really important / the code isn't in this stack of diffs somewhere, i'd put the note here

This revision is now accepted and ready to land.Jun 3 2014, 10:11 PM
epriestley added a comment.Jun 4 2014, 1:02 AM

D9292 is the one that adds the compression bit.

epriestley closed this revision.Jun 4 2014, 1:03 AM
epriestley updated this revision to Diff 22330.

Closed by commit rP5b1262c98b8f (authored by @epriestley).

Revision Contents
Changeset List

PathSize
bin/
1 line
scripts/
setup/
21 lines
src/
4 lines
applications/
differential/
management/
48 lines
6 lines
storage/
2 lines

Diff 22058

View Options

bin/hunks

Loading...
View Options

scripts/setup/manage_hunks.php

Loading...
View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/differential/management/PhabricatorHunksManagementMigrateWorkflow.php

Loading...
View Options

src/applications/differential/management/PhabricatorHunksManagementWorkflow.php

Loading...
View Options

src/applications/differential/storage/DifferentialHunk.php

Loading...
Phabricator · Built by Phacility