"Blocks" instead of "Dependent Tasks"
ClosedPublic
Actions

Authored by lpriestley on May 23 2014, 4:57 PM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Maniphest Tasks

T5021: "Blocks" instead of "Dependent Tasks"

Commits

Restricted Diffusion Commit
rP6a80b6a588c8: "Blocks" instead of "Dependent Tasks"

Summary

Fixes T5021, UI labels for the fields, "Edit Dependencies" in the action list, transaction strings ("added dependent tasks", etc), UI strings in the dependencies dialog (title/submit/etc)

Test Plan

Open task, edit blocks, dialog should have new term, task history should show "blocks" instead of "dependencies"

Diff Detail

Repository

rP Phabricator

Branch

renameblocks

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 671
Build 671: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

lpriestley updated this revision to Diff 22013.May 23 2014, 4:57 PM

lpriestley retitled this revision from to "Blocks" instead of "Dependent Tasks".

lpriestley updated this object.

lpriestley edited the test plan for this revision. (Show Details)

lpriestley added a reviewer: epriestley.

lpriestley added a task: T5021: "Blocks" instead of "Dependent Tasks".

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptMay 23 2014, 4:57 PM

Herald added subscribers: Korvin, epriestley. · View Herald Transcript

Harbormaster completed remote builds in B671: Diff 22013.May 23 2014, 4:58 PM

Two small wordsmithing things.

src/applications/maniphest/controller/ManiphestTaskDetailController.php
473	I think "Edit Blockers" (or, probably, "Edit Blocking Tasks") would be more clear/consistent.
src/applications/search/controller/PhabricatorSearchAttachController.php
266–268	These should have `pht()`, and probably be "Edit Blocking Tasks", etc.