Page MenuHomePhabricator

Capture maximum version information in `php_compat_info`.
ClosedPublic

Authored by joshuaspence on May 21 2014, 9:43 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Nov 18, 1:47 AM
Unknown Object (File)
Thu, Nov 14, 8:27 AM
Unknown Object (File)
Tue, Nov 12, 10:46 PM
Unknown Object (File)
Sun, Nov 10, 1:20 PM
Unknown Object (File)
Sat, Nov 9, 5:37 PM
Unknown Object (File)
Wed, Nov 6, 12:33 AM
Unknown Object (File)
Thu, Oct 24, 11:24 PM
Unknown Object (File)
Oct 11 2024, 3:45 PM
Subscribers

Details

Summary

Ref T5141. In order to be able to warn when deprecated functions are used, we need to be aware of from which version the functions were deprecated.

Test Plan

Ran arc lint and made sure no unexpected warnings were raised.

Diff Detail

Repository
rARC Arcanist
Branch
php_compat_info-minmax
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 642
Build 642: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence retitled this revision from to Capture maximum version information in `php_compat_info`..
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.

How long does parsing a 14,000 line JSON file take?

Before

> time php -r 'json_decode(file_get_contents("./resources/php_compat_info.json"), true);'

real	0m0.027s
user	0m0.018s
sys	0m0.009s

After

> time php -r 'json_decode(file_get_contents("./resources/php_compat_info.json"), true);'

real	0m0.034s
user	0m0.024s
sys	0m0.010s
epriestley edited edge metadata.
This revision is now accepted and ready to land.May 22 2014, 4:14 PM
epriestley updated this revision to Diff 21976.

Closed by commit rARCe0ee3e8a07ba (authored by @joshuaspence, committed by @epriestley).