Page MenuHomePhabricator
Differential D9066

Allow `ArcanistPhutilXHPASTLinter` to be configured from `.arclint`.
ClosedPublic
Actions

Authored by joshuaspence on May 12 2014, 3:17 AM.
Tags
None
Referenced Files
F13259346: D9066.diff
Sun, May 26, 7:39 PM
F13219033: D9066.diff
Sat, May 18, 2:38 PM
F13210476: D9066.diff
Fri, May 17, 4:53 AM
F13194189: D9066.diff
Sun, May 12, 9:23 PM
F13177250: D9066.diff
Wed, May 8, 7:34 PM
Unknown Object (File)
Apr 29 2024, 2:11 PM
Unknown Object (File)
Apr 27 2024, 6:03 PM
Unknown Object (File)
Apr 24 2024, 10:00 PM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Maniphest Tasks
Restricted Maniphest Task
Commits
rARC1b820dbb1479: Allow `ArcanistPhutilXHPASTLinter` to be configured from `.arclint`.
Summary

Currently, PhabricatorLintEngine configures the ArcanistPhutilXHPASTLinter linter. In order to use .arclint instead, we need to expose the ArcanistPhutilXHPASTLinter configuration to the .arclint format.

Test Plan

See D9064.

Diff Detail

Repository
rARC Arcanist
Branch
phab-arclint
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 388
Build 388: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence updated this revision to Diff 21527.May 12 2014, 3:17 AM
joshuaspence retitled this revision from to Allow `ArcanistPhutilXHPASTLinter` to be configured from `.arclint`..
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptMay 12 2014, 3:17 AM
Herald added subscribers: Korvin, epriestley. · View Herald Transcript
Harbormaster completed remote builds in B385: Diff 21527.May 12 2014, 3:18 AM
epriestley requested changes to this revision.May 12 2014, 3:25 AM
epriestley edited edge metadata.
  • This should rebase on D9062 and pick up the 'type' / 'help' keys for arc linters --verbose.
  • Per D9064#19, I favor namespacing.
This revision now requires changes to proceed.May 12 2014, 3:25 AM
joshuaspence updated this revision to Diff 21532.May 12 2014, 4:02 AM
joshuaspence edited edge metadata.
  • Rebase against master.
  • Namespace configuration options.
Harbormaster completed remote builds in B388: Diff 21532.May 12 2014, 4:03 AM
joshuaspence updated this revision to Diff 21534.May 12 2014, 4:05 AM
joshuaspence edited edge metadata.

Also namespace the configuration options in setLinterConfigurationValue.

Harbormaster completed remote builds in B390: Diff 21534.May 12 2014, 4:06 AM
joshuaspence added a task: Restricted Maniphest Task.May 12 2014, 10:27 AM
epriestley accepted this revision.May 12 2014, 11:46 AM
epriestley edited edge metadata.
This revision is now accepted and ready to land.May 12 2014, 11:46 AM
epriestley closed this revision.May 12 2014, 11:46 AM
epriestley updated this revision to Diff 21540.

Closed by commit rARC1b820dbb1479 (authored by @joshuaspence, committed by @epriestley).

Revision Contents
Changeset List

PathSize
src/
lint/
linter/
40 lines

Diff 21532

View Options

src/lint/linter/ArcanistPhutilXHPASTLinter.php

Loading...
Phabricator · Built by Phacility