Provide `arc linters --verbose` to list all available options
ClosedPublic
Actions

Authored by epriestley on May 12 2014, 2:33 AM.

Details

Reviewers

joshuaspence
btrahan

Maniphest Tasks

Restricted Maniphest Task

Commits

rARC54c377448db8: Provide `arc linters --verbose` to list all available options

Summary

Ref T2039. I'll update the corresponding documentation.

It feels a little awkward that this is disconnected from getLinterConfigurationOptions(), but I dislike returning weird ad-hoc structures more than I dislike having two methods. Most linters don't implement either of these anyway.

Test Plan

Ran arc linters and arc linters --verbose.

Diff Detail

Repository

rARC Arcanist

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

epriestley updated this revision to Diff 21519.May 12 2014, 2:33 AM

epriestley retitled this revision from to Provide `arc linters --verbose` to list all available options.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added reviewers: joshuaspence, btrahan.

epriestley added a task: Restricted Maniphest Task.

Herald added a subscriber: epriestley. · View Herald TranscriptMay 12 2014, 2:33 AM

Harbormaster completed remote builds in B379: Diff 21519.May 12 2014, 2:34 AM

I disagree with you, I think amending getLinterConfigurationOptions to return something like:

public function getLinterConfigurationOptions() {
  ...

  return array(
    'severity' => array(
      'type' => 'optional map<string|int, string>',
      'info' => pht(
        'Provide a map from lint codes to adjusted severity levels: error, '.
        'warning, advice, autofix or disabled.')
    'severity.rules' => array(
      'type' => 'optional map<string, string>',
      'info' => pht(
        'Provide a map of regular expressions to severity levels. All '.
        'matching codes have their severity adjusted.')
  );
}

This revision now requires changes to proceed.May 12 2014, 2:53 AM