Add 'arc linters' to list available linters and status
ClosedPublic
Actions

Authored by epriestley on May 10 2014, 10:20 AM.

Details

Reviewers

joshuaspence
btrahan

Maniphest Tasks

Restricted Maniphest Task

Commits

rARCe13f5839d4e8: Add 'arc linters' to list available linters and status

Summary

Ref T2039. We're starting to get kind of a lot of linters; provide arc linters to help users review and understand them and construct .arclint files.

Test Plan

Screen_Shot_2014-05-10_at_3.17.25_AM.png (1×1 px, 219 KB)

Diff Detail

Repository

rARC Arcanist

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

epriestley updated this revision to Diff 21473.May 10 2014, 10:20 AM

epriestley retitled this revision from to Add 'arc linters' to list available linters and status.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added reviewers: joshuaspence, btrahan.

epriestley added a task: Restricted Maniphest Task.

Herald added a subscriber: epriestley. · View Herald TranscriptMay 10 2014, 10:20 AM

Harbormaster completed remote builds in B344: Diff 21473.May 10 2014, 10:21 AM

I want to look over the code in more detail in a few hours time, but this looks really good.

btrahan accepted this revision.May 10 2014, 5:02 PM

btrahan edited edge metadata.

This revision is now accepted and ready to land.May 10 2014, 5:02 PM

avivey awarded a token.May 10 2014, 7:27 PM

chad awarded a token.May 10 2014, 8:30 PM

joshuaspence awarded a token.May 10 2014, 11:15 PM

LGTM.

src/lint/linter/ArcanistSpellingLinter.php
19	"Spell Checker" or "spellchecker"? I'm honestly not sure which is more correct.
src/workflow/ArcanistLintersWorkflow.php
21–25	This isn't specific to this diff, but it seems flimsy to have to provide the correct amount of indentation (and wrapping) here. It would be nicer if in this method we could just specify an (unwrapped) string and have `ArcanistBaseWorkflow` take care of indentation and wrapping.