Paths

Table of Contentst

Differential D8987

Fix `flake8` unit test.
ClosedPublic
Actions

Authored by joshuaspence on May 6 2014, 1:52 AM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Commits

rARC213997dc9d6b: Fix `flake8` unit test.

Summary

This unit test is failing for me. It seems that I have a newer version of flake8. We should probably provide support for the most recent versions of any external tools, at least until we can implement version-specific stuff.

I am running 2.1.0 (pep8: 1.5.6, pyflakes: 0.8.1, mccabe: 0.2.1) CPython 2.7.6 on Linux.

Test Plan

arc unit.

Diff Detail

Repository

rARC Arcanist

Branch

flake8-tests

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 259
Build 259: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence updated this revision to Diff 21339.May 6 2014, 1:52 AM

joshuaspence retitled this revision from to Fix `flake8` unit test..

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptMay 6 2014, 1:52 AM

Herald added subscribers: Korvin, epriestley. · View Herald Transcript

Harbormaster completed remote builds in B259: Diff 21339.May 6 2014, 1:53 AM

Yep, agreed. This looks like it's a better result anyway (the message is more accurate).

This revision is now accepted and ready to land.May 6 2014, 1:59 AM

Closed by commit rARC213997dc9d6b (authored by @joshuaspence, committed by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

lint/

linter/

__tests__/

flake8/

undefined.lint-test

2 lines

Diff 21339

View Options

src/lint/linter/tests/flake8/undefined.lint-test

Fix `flake8` unit test.ClosedPublicActions