HomePhabricator

Add a `getVersion` function to `ArcanistExternalLinter`.

Description

Add a getVersion function to ArcanistExternalLinter.

Summary:
This method will, theoretically, allow arc lint to be configured to require some minimum version of an external linter (although this would probably require significantly more work).

Additionally, the existence of this method simplifies the getCacheVersion function which, previously, was implemented by the external linters individually. Instead, a general approach to determining the version for cacheing purposes can be used.

Fixes T4954.

Test Plan: I'm not sure how to test this.

Reviewers: chad, epriestley, Blessed Reviewers

Reviewed By: epriestley, Blessed Reviewers

Subscribers: epriestley, Korvin

Maniphest Tasks: T4954

Differential Revision: https://secure.phabricator.com/D8971

Details

Provenance
joshuaspenceAuthored on
epriestleyCommitted on May 5 2014, 10:10 PM
epriestleyPushed on May 5 2014, 10:10 PM
Reviewer
Blessed Reviewers
Differential Revision
D8971: Add a `getVersion` function to `ArcanistExternalLinter`.
Parents
rARCa7327ca0e943: Modernize `ArcanistJSHintLinter`.
Branches
Unknown
Tags
Unknown
Tasks
T4954: Allow version dependencies to be specified for external linters

Event Timeline