Fix issue with ref/fixes in commit messages
ClosedPublic
Actions

Authored by epriestley on Mar 13 2014, 10:04 PM.

Tags

None

Referenced Files

	F13177604: D8519.diff
	Wed, May 8, 7:50 PM

	Unknown Object (File)
	Mon, Apr 29, 4:05 PM

	Unknown Object (File)
	Sat, Apr 27, 9:39 PM

	Unknown Object (File)
	Sat, Apr 27, 9:39 PM

	Unknown Object (File)
	Sat, Apr 27, 9:39 PM

	Unknown Object (File)
	Fri, Apr 26, 8:37 AM

	Unknown Object (File)
	Wed, Apr 24, 10:30 PM

	Unknown Object (File)
	Thu, Apr 11, 9:08 AM

Subscribers

Details

Reviewers

btrahan

Maniphest Tasks

T4600: "Fixes ___" in differentials and commits no longer closes tasks

Commits

Restricted Diffusion Commit
rP1d303542235d: Fix issue with ref/fixes in commit messages

Summary

Fixes T4600. If there's also a revision, the variable "$message" gets overwritten. groan~

Test Plan

Pushed a commit with "Fixes T123" and a revision, saw it parse on the first try.

Diff Detail

Repository

rP Phabricator

Branch

shadowvar

Lint

Lint Passed

Unit

Tests Passed

Event Timeline

epriestley updated this revision to Diff 20215.Mar 13 2014, 10:04 PM

epriestley retitled this revision from to Fix issue with ref/fixes in commit messages.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: btrahan.

epriestley added a task: T4600: "Fixes ___" in differentials and commits no longer closes tasks.

Herald added subscribers: epriestley, aran.Mar 13 2014, 10:04 PM

btrahan accepted this revision.Mar 14 2014, 12:40 AM

btrahan edited edge metadata.

This revision is now accepted and ready to land.Mar 14 2014, 12:40 AM

Closed by commit rP1d303542235d (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

applications/

repository/

worker/

commitmessageparser/

PhabricatorRepositoryCommitMessageParserWorker.php

6 lines

Diff 20215

View Options

src/applications/repository/worker/commitmessageparser/PhabricatorRepositoryCommitMessageParserWorker.php

Fix issue with ref/fixes in commit messagesClosedPublicActions