Page MenuHomePhabricator

"Fixes ___" in differentials and commits no longer closes tasks
Closed, ResolvedPublic

Description

It used to be that I could add 'Fixes T12345' to the Summary section when I do arc diff, and when I eventually landed that differential, the associated task would be closed. This isn't working for us anymore. I believe this broke sometime when we updated from d08576ed4e99 to ad88ff28a1b5. I'm a bit suspicious of 40b471faea91.

Event Timeline

lexelby raised the priority of this task from to Needs Triage.
lexelby updated the task description. (Show Details)
lexelby added a project: Phabricator.
lexelby added a subscriber: lexelby.

FYI, we just pulled and we can still reproduce the issue.

I've seen this but haven't been able to reproduce it in isolation yet. 40b471faea91 is probably the correct change to be suspicious of. This has manifested as a heisenbug in my attempts to pursue it: it works properly locally, it works properly when the parser is re-run manually, but it doesn't work in the field. I'll keep digging into this.

Odd... we seem to be able to reproduce it every time we try. Let me know if there's any more information I can provide you.

Yeah -- it reproduces every time I push something to this install, but when I re-run the parse step it fixes it. It works immediately on my local install. I'm sure it's something silly, I just need to dig into it a bit.

The trick was that you needed both "Differential Revision" and "Fixes" to trigger the bug, and the second time through things would work (since the first time through would handle the "Differential Revision" part). My working test cases just had "Fixes".

Amusingly, you've reproduced the bug while fixing it ;)

epriestley claimed this task.

I landed rARC1e6d958, which correctly closed T4603, so I think this is fixed in practice.