HomePhabricator

Added 'method' field to the HTTP request build step.

Description

Added 'method' field to the HTTP request build step.

Summary:
This revision adds a 'method' field to the HTTP request harbormaster build step. This allows the user to specify GET, POST, DELETE, and PUT (limited by the underlying wrapper phabricator uses for HTTP requests). I'm not sure how much sense PUT makes, but oh well.

Existing plans shouldn't break, as if this field is an empty string, we default to POST, which is the old behavior.

Fixes T4604

Test Plan: 1) Verified that the empty string does, in fact, issue a POST request. Changed the method to be GET and observed that the problem described in T4604 is resolved.

Reviewers: Blessed Reviewers, epriestley

Reviewed By: Blessed Reviewers, epriestley

Subscribers: aran, epriestley

Maniphest Tasks: T4604

Differential Revision: https://secure.phabricator.com/D8520

Details

Provenance
wotteAuthored on
epriestleyCommitted on Mar 13 2014, 10:51 PM
epriestleyPushed on Mar 13 2014, 10:51 PM
Reviewer
Blessed Reviewers
Differential Revision
D8520: Added 'method' field to the HTTP request build step.
Parents
rPe6118bcbaf7d: Tweak application and maniphest editors to handle policy corner cases better
Branches
Unknown
Tags
Unknown

Event Timeline