Page MenuHomePhabricator
Differential D8451

Use CustomField for `differential.updaterevision`
ClosedPublic
Actions

Authored by epriestley on Mar 8 2014, 6:56 PM.
Tags
None
Referenced Files
F15543726: D8451.id20112.diff
Sat, Apr 26, 12:39 AM
F15540796: D8451.id.diff
Fri, Apr 25, 8:57 AM
F15538421: D8451.diff
Thu, Apr 24, 7:16 PM
F15517539: D8451.diff
Sat, Apr 19, 3:39 AM
F15431067: D8451.id.diff
Mar 24 2025, 10:19 AM
F15428511: D8451.id20112.diff
Mar 23 2025, 8:53 PM
F15424332: D8451.diff
Mar 22 2025, 9:33 PM
F15402423: D8451.id20112.diff
Mar 17 2025, 10:27 PM
View All Files
Subscribers
aran

Details

Reviewers
btrahan
Maniphest Tasks
T3794: Rebuild Diffusion/Audit on top of CustomField infrastructure
T2222: Implement ApplicationTransactions in Differential
Commits
Restricted Diffusion Commit
rPd8968755e9d1: Use CustomField for `differential.updaterevision`
Summary

Ref T2222. Ref T3794. Medium term goal is to remove DifferentialRevisionEditor. This removes one of two callsites.

Test Plan

Used arc diff --edit to repeatedly update a revision, making changes to various fields.

Diff Detail

Repository
rP Phabricator
Branch
dx12
Lint
Lint Passed
SeverityLocationCodeMessage
Advicesrc/applications/differential/conduit/ConduitAPI_differential_updaterevision_Method.php:97XHP16TODO Comment
Unit
Tests Passed

Event Timeline

btrahan accepted this revision.Mar 10 2014, 4:28 PM
btrahan edited edge metadata.
This revision is now accepted and ready to land.Mar 10 2014, 4:28 PM
epriestley closed this revision.Mar 11 2014, 8:06 PM
epriestley updated this revision to Diff 20112.

Closed by commit rPd8968755e9d1 (authored by @epriestley).

Revision Contents
Changeset List

PathSize
src/
applications/
differential/
conduit/
123 lines
customfield/
35 lines
transactions/
editor/
1 line

Diff 20056

View Options

src/applications/differential/conduit/ConduitAPI_differential_updaterevision_Method.php

Loading...
View Options

src/applications/differential/customfield/DifferentialManiphestTasksField.php

Loading...
View Options

src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php

Loading...
Phabricator · Built by Phacility