Page MenuHomePhabricator

Perform commit message parsing and construction with new CustomFields
ClosedPublic

Authored by epriestley on Mar 8 2014, 5:01 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Feb 24, 11:34 AM
Unknown Object (File)
Fri, Feb 21, 3:32 AM
Unknown Object (File)
Sun, Feb 9, 11:48 AM
Unknown Object (File)
Sun, Feb 9, 11:48 AM
Unknown Object (File)
Sun, Feb 9, 11:48 AM
Unknown Object (File)
Sun, Feb 9, 11:48 AM
Unknown Object (File)
Thu, Feb 6, 8:08 PM
Unknown Object (File)
Jan 28 2025, 11:30 PM
Subscribers

Details

Summary

Ref T2222. Ref T3886. Converts parsing and construction of commit messages to be driven by CustomField.

Test Plan

This is a huge, messy change. I've made an effort to test it exhasutively, but suspect I probably missed a few behaviors. Roughly:

  • Enumerted all current fields (fields implementing shouldAppearOnCommitMessage()) and tried to test them one by one.
  • Used arc diff --edit repeatedly to manipulate each field (this workflow hits both the parse and construct steps).
  • Used arc amend --show to examine construct output (this does not activate the "edit" mode).

Diff Detail

Repository
rP Phabricator
Branch
dx10
Lint
Lint Passed
SeverityLocationCodeMessage
Advicesrc/applications/differential/customfield/DifferentialCustomField.php:13XHP16TODO Comment
Unit
Tests Passed

Event Timeline

btrahan edited edge metadata.
This revision is now accepted and ready to land.Mar 10 2014, 4:24 PM
epriestley updated this revision to Diff 20114.

Closed by commit rPae3c1f781939 (authored by @epriestley).