Page MenuHomePhabricator

Perform commit message parsing and construction with new CustomFields
ClosedPublic

Authored by epriestley on Mar 8 2014, 5:01 PM.
Tags
None
Referenced Files
F15545719: D8449.id20052.diff
Sat, Apr 26, 12:15 PM
F15526502: D8449.diff
Mon, Apr 21, 9:09 PM
F15520432: D8449.id.diff
Sun, Apr 20, 6:33 AM
F15519991: D8449.id20114.diff
Sun, Apr 20, 2:10 AM
F15511738: D8449.id.diff
Thu, Apr 17, 5:07 AM
F15511035: D8449.diff
Wed, Apr 16, 11:36 PM
F15473175: D8449.diff
Sat, Apr 5, 7:52 PM
F15472912: D8449.id20114.diff
Sat, Apr 5, 5:44 PM
Subscribers

Details

Summary

Ref T2222. Ref T3886. Converts parsing and construction of commit messages to be driven by CustomField.

Test Plan

This is a huge, messy change. I've made an effort to test it exhasutively, but suspect I probably missed a few behaviors. Roughly:

  • Enumerted all current fields (fields implementing shouldAppearOnCommitMessage()) and tried to test them one by one.
  • Used arc diff --edit repeatedly to manipulate each field (this workflow hits both the parse and construct steps).
  • Used arc amend --show to examine construct output (this does not activate the "edit" mode).

Diff Detail

Repository
rP Phabricator
Branch
dx10
Lint
Lint Passed
SeverityLocationCodeMessage
Advicesrc/applications/differential/customfield/DifferentialCustomField.php:13XHP16TODO Comment
Unit
Tests Passed

Event Timeline

btrahan edited edge metadata.
This revision is now accepted and ready to land.Mar 10 2014, 4:24 PM
epriestley updated this revision to Diff 20114.

Closed by commit rPae3c1f781939 (authored by @epriestley).