Page MenuHomePhabricator

Perform commit message parsing and construction with new CustomFields
ClosedPublic

Authored by epriestley on Mar 8 2014, 5:01 PM.
Tags
None
Referenced Files
F18770268: D8449.id20114.diff
Wed, Oct 8, 11:40 AM
F18759680: D8449.id.diff
Mon, Oct 6, 5:19 AM
F18758459: D8449.diff
Sun, Oct 5, 10:25 PM
F18683071: D8449.id20052.diff
Sep 26 2025, 6:59 AM
F18607268: D8449.diff
Sep 13 2025, 11:45 PM
F18594003: D8449.diff
Sep 12 2025, 4:41 PM
F18454216: D8449.id.diff
Sep 1 2025, 4:55 AM
F18446672: D8449.diff
Aug 31 2025, 10:12 PM
Subscribers

Details

Summary

Ref T2222. Ref T3886. Converts parsing and construction of commit messages to be driven by CustomField.

Test Plan

This is a huge, messy change. I've made an effort to test it exhasutively, but suspect I probably missed a few behaviors. Roughly:

  • Enumerted all current fields (fields implementing shouldAppearOnCommitMessage()) and tried to test them one by one.
  • Used arc diff --edit repeatedly to manipulate each field (this workflow hits both the parse and construct steps).
  • Used arc amend --show to examine construct output (this does not activate the "edit" mode).

Diff Detail

Repository
rP Phabricator
Branch
dx10
Lint
Lint Passed
SeverityLocationCodeMessage
Advicesrc/applications/differential/customfield/DifferentialCustomField.php:13XHP16TODO Comment
Unit
Tests Passed

Event Timeline

btrahan edited edge metadata.
This revision is now accepted and ready to land.Mar 10 2014, 4:24 PM
epriestley updated this revision to Diff 20114.

Closed by commit rPae3c1f781939 (authored by @epriestley).