Page MenuHomePhabricator

Add puppet-lint linter
AbandonedPublic

Authored by joshuaspence on Mar 5 2014, 10:34 PM.

Details

Reviewers
epriestley
aripringle
Group Reviewers
Blessed Reviewers
Summary

Add ArcanistPuppetLintLinter class to test Puppet manifest files. Relies on the puppet-lint ruby gem.

Test Plan

New test written. Also did manual testing of warnings, errors, and files with no lint messages. Verified that .arcconfig options work as expected.

Diff Detail

Repository
rARC Arcanist
Branch
master
Lint
Lint Passed
Unit
Test Failures

Event Timeline

This generally looks good, but we should make two changes which aren't entirely straightforward:

  • Let's wait for D8387 and use that style (array of flags instead of string).
  • I don't want to add new .arcconfig options, since .arclint will obsolete them. However, .arclint is in a weird limbo right now and we don't have a solid technical approach for deprecating .arcconfig options or letting you use older linters easily without introducing them. Let me come up with a more concrete approach here.

I'll follow up with specific guidance once some of the ambiguity here clears up. Ideally, I'd like to get .arclint pushed forward enough to start recommending it, but I'm not sure how my priorities will line up.

joshuaspence added a reviewer: aripringle.
joshuaspence added a subscriber: joshuaspence.

This is fixed by D8990.