Page MenuHomePhabricator

Add a `puppet-lint` linter.
ClosedPublic

Authored by joshuaspence on May 6 2014, 3:26 AM.

Details

Summary

This linter is a wrapper around puppet-lint.

Test Plan

Wrote an executed unit tests.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

joshuaspence retitled this revision from to Add a `puppet-lint` linter..
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
epriestley edited edge metadata.

Minor technical nits, but the sprintf() seems like a leftover?

src/lint/linter/ArcanistPuppetLintLinter.php
46

sprintf('%s', ...) has no effect?

59

Maybe explode('|', $line, 5) to handle the case where %{message} contains | for some reason?

This revision now requires changes to proceed.May 6 2014, 3:30 AM
src/lint/linter/ArcanistPuppetLintLinter.php
46

Yep, let me do this a better way.

59

Good catch.

epriestley edited edge metadata.
This revision is now accepted and ready to land.May 6 2014, 3:42 AM
epriestley updated this revision to Diff 21351.

Closed by commit rARC8523b98f396d (authored by @joshuaspence, committed by @epriestley).