Paths

Table of Contentst

Differential D8990

Add a `puppet-lint` linter.
ClosedPublic
Actions

Authored by joshuaspence on May 6 2014, 3:26 AM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Commits

rARC8523b98f396d: Add a `puppet-lint` linter.

Summary

This linter is a wrapper around puppet-lint.

Test Plan

Wrote an executed unit tests.

Diff Detail

Repository

rARC Arcanist

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

joshuaspence updated this revision to Diff 21347.May 6 2014, 3:26 AM

joshuaspence retitled this revision from to Add a `puppet-lint` linter..

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptMay 6 2014, 3:26 AM

Herald added subscribers: Korvin, epriestley. · View Herald Transcript

Harbormaster completed remote builds in B263: Diff 21347.May 6 2014, 3:27 AM

Minor technical nits, but the sprintf() seems like a leftover?

src/lint/linter/ArcanistPuppetLintLinter.php
46	`sprintf('%s', ...)` has no effect?
59	Maybe `explode('\|', $line, 5)` to handle the case where `%{message}` contains `\|` for some reason?

This revision now requires changes to proceed.May 6 2014, 3:30 AM

joshuaspence added inline comments.May 6 2014, 3:41 AM

src/lint/linter/ArcanistPuppetLintLinter.php
46	Yep, let me do this a better way.
59	Good catch.

Minor changes.

epriestley accepted this revision.May 6 2014, 3:42 AM

epriestley edited edge metadata.

This revision is now accepted and ready to land.May 6 2014, 3:42 AM

Closed by commit rARC8523b98f396d (authored by @joshuaspence, committed by @epriestley).

Harbormaster completed remote builds in B265: Diff 21350.May 6 2014, 3:43 AM

joshuaspence updated this object.May 6 2014, 3:58 AM

joshuaspence edited edge metadata.

Revision Contents
Changeset List

Path

Size

src/

__phutil_library_map__.php

4 lines

lint/

linter/

ArcanistPuppetLintLinter.php

92 lines

__tests__/

ArcanistPuppetLintLinterTestCase.php

12 lines

puppet-lint/

2sp_soft_tabs.lint-test

7 lines

arrow_alignment.lint-test

6 lines

double_quoted_strings.lint-test

7 lines

duplicate_params.lint-test

6 lines

ensure_not_symlink_target.lint-test

5 lines

file_mode.lint-test

6 lines

hard_tabs.lint-test

7 lines

names_containing_dash.lint-test

3 lines

quoted_booleans.lint-test

6 lines

right_to_left_relationship.lint-test

3 lines

site.lint-test

19 lines

slash_comments.lint-test

3 lines

star_comments.lint-test

3 lines

unquoted_file_mode.lint-test

6 lines

Diff 21351

View Options

src/__phutil_library_map__.php

View Options

src/lint/linter/ArcanistPuppetLintLinter.php

View Options

src/lint/linter/tests/ArcanistPuppetLintLinterTestCase.php

View Options

src/lint/linter/tests/puppet-lint/2sp_soft_tabs.lint-test

View Options

src/lint/linter/tests/puppet-lint/arrow_alignment.lint-test

View Options

src/lint/linter/tests/puppet-lint/double_quoted_strings.lint-test

View Options

src/lint/linter/tests/puppet-lint/duplicate_params.lint-test

View Options

src/lint/linter/tests/puppet-lint/ensure_not_symlink_target.lint-test

View Options

src/lint/linter/tests/puppet-lint/file_mode.lint-test

View Options

src/lint/linter/tests/puppet-lint/hard_tabs.lint-test

View Options

src/lint/linter/tests/puppet-lint/names_containing_dash.lint-test

View Options

src/lint/linter/tests/puppet-lint/quoted_booleans.lint-test

View Options

src/lint/linter/tests/puppet-lint/right_to_left_relationship.lint-test

View Options

src/lint/linter/tests/puppet-lint/site.lint-test

View Options

src/lint/linter/tests/puppet-lint/slash_comments.lint-test

View Options

src/lint/linter/tests/puppet-lint/star_comments.lint-test

View Options

src/lint/linter/tests/puppet-lint/unquoted_file_mode.lint-test

Add a `puppet-lint` linter.ClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 21351

src/__phutil_library_map__.php

src/lint/linter/ArcanistPuppetLintLinter.php

src/lint/linter/__tests__/ArcanistPuppetLintLinterTestCase.php

src/lint/linter/__tests__/puppet-lint/2sp_soft_tabs.lint-test

src/lint/linter/__tests__/puppet-lint/arrow_alignment.lint-test

src/lint/linter/__tests__/puppet-lint/double_quoted_strings.lint-test

src/lint/linter/__tests__/puppet-lint/duplicate_params.lint-test

src/lint/linter/__tests__/puppet-lint/ensure_not_symlink_target.lint-test

src/lint/linter/__tests__/puppet-lint/file_mode.lint-test

src/lint/linter/__tests__/puppet-lint/hard_tabs.lint-test

src/lint/linter/__tests__/puppet-lint/names_containing_dash.lint-test

src/lint/linter/__tests__/puppet-lint/quoted_booleans.lint-test

src/lint/linter/__tests__/puppet-lint/right_to_left_relationship.lint-test

src/lint/linter/__tests__/puppet-lint/site.lint-test

src/lint/linter/__tests__/puppet-lint/slash_comments.lint-test

src/lint/linter/__tests__/puppet-lint/star_comments.lint-test

src/lint/linter/__tests__/puppet-lint/unquoted_file_mode.lint-test

Add a `puppet-lint` linter.
ClosedPublic
Actions

Revision Contents
Changeset List

src/lint/linter/tests/ArcanistPuppetLintLinterTestCase.php

src/lint/linter/tests/puppet-lint/2sp_soft_tabs.lint-test

src/lint/linter/tests/puppet-lint/arrow_alignment.lint-test

src/lint/linter/tests/puppet-lint/double_quoted_strings.lint-test

src/lint/linter/tests/puppet-lint/duplicate_params.lint-test

src/lint/linter/tests/puppet-lint/ensure_not_symlink_target.lint-test

src/lint/linter/tests/puppet-lint/file_mode.lint-test

src/lint/linter/tests/puppet-lint/hard_tabs.lint-test

src/lint/linter/tests/puppet-lint/names_containing_dash.lint-test

src/lint/linter/tests/puppet-lint/quoted_booleans.lint-test

src/lint/linter/tests/puppet-lint/right_to_left_relationship.lint-test

src/lint/linter/tests/puppet-lint/site.lint-test

src/lint/linter/tests/puppet-lint/slash_comments.lint-test

src/lint/linter/tests/puppet-lint/star_comments.lint-test

src/lint/linter/tests/puppet-lint/unquoted_file_mode.lint-test