Paths

Table of Contentst

Correctly identify `@todo` comments as TODOs.
ClosedPublic
Actions

Authored by joshuaspence on Mar 3 2014, 12:17 PM.

Tags

None

Referenced Files

	F13238589: D8389.diff
	Tue, May 21, 8:12 PM

	F13223512: D8389.diff
	Sun, May 19, 4:40 AM

	F13198706: D8389.diff
	Mon, May 13, 9:07 AM

	Unknown Object (File)
	Fri, May 3, 9:10 AM

	Unknown Object (File)
	Sun, Apr 28, 5:35 AM

	Unknown Object (File)
	Sun, Apr 28, 4:25 AM

	Unknown Object (File)
	Sun, Apr 28, 4:25 AM

	Unknown Object (File)
	Thu, Apr 25, 12:12 AM

Subscribers

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Commits

rARCfb826bbf9cf0: Correctly identify `@todo` comments as TODOs.

Summary

Allow @todo comments to be linted as TODOs as well as TODO comments.

Test Plan

I added a new test case (todo.lint-test)

Diff Detail

Repository

rARC Arcanist

Branch

xhpast_todo

Lint

Lint Passed

Unit

Test Failures

Event Timeline

Seems reasonable to me.

This revision is now accepted and ready to land.Mar 4 2014, 7:03 PM

Closed by commit rARCfb826bbf9cf0 (authored by @joshuaspence, committed by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

lint/

linter/

ArcanistXHPASTLinter.php

8 lines

__tests__/

xhpast/

todo.lint-test

10 lines

Diff 19925

View Options

src/lint/linter/ArcanistXHPASTLinter.php

View Options

src/lint/linter/tests/xhpast/todo.lint-test

Correctly identify `@todo` comments as TODOs.ClosedPublicActions