D8389.diff
No OneTemporary
Actions

Size

943 B

Referenced Files

None

Subscribers

None

D8389.diff
View Options

	Index: src/lint/linter/ArcanistXHPASTLinter.php
	===================================================================
	--- src/lint/linter/ArcanistXHPASTLinter.php
	+++ src/lint/linter/ArcanistXHPASTLinter.php
	@@ -2036,9 +2036,15 @@

	foreach ($comments as $token) {
	$value = $token->getValue();
	+ if ($token->getTypeName() === 'T_DOC_COMMENT') {
	+ $regex = '/(TODO\|@todo)/';
	+ } else {
	+ $regex = '/TODO/';
	+ }
	+
	$matches = null;
	$preg = preg_match_all(
	- '/TODO/',
	+ $regex,
	$value,
	$matches,
	PREG_OFFSET_CAPTURE);
	Index: src/lint/linter/__tests__/xhpast/todo.lint-test
	===================================================================
	--- /dev/null
	+++ src/lint/linter/__tests__/xhpast/todo.lint-test
	@@ -0,0 +1,10 @@
	+<?php
	+
	+// TODO: Something goes here.
	+
	+/**
	+ * @todo Something else goes here.
	+ */
	+~~~~~~~~~~
	+disabled:3:4
	+disabled:6:4