Page MenuHomePhabricator

Don't consider integer CustomFields as changed when the number doesn't change
ClosedPublic

Authored by epriestley on Feb 21 2014, 4:52 PM.
Tags
None
Referenced Files
F19799825: D8292.id.diff
Feb 28 2026, 5:58 AM
F19695167: D8292.diff
Feb 10 2026, 12:08 PM
F19631114: D8292.diff
Feb 5 2026, 3:21 AM
F19604195: D8292.diff
Feb 3 2026, 7:47 AM
F19553996: D8292.id19720.diff
Jan 29 2026, 4:33 PM
F19553994: D8292.id19719.diff
Jan 29 2026, 4:33 PM
F19523396: D8292.diff
Jan 17 2026, 4:20 PM
F19152086: D8292.diff
Dec 11 2025, 12:32 AM
Subscribers

Details

Summary

Fixes T4466. We do an excessively strict effect check now, which means that these fields changing from (string) "16" to (int) 16 generates a transaction. Instead, compare integer values if the field has data in it.

Test Plan

{F116261}

(Also made updates without changing the number, which did not appear in the transaction log anymore.)

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped