Page MenuHomePhabricator

Don't consider integer CustomFields as changed when the number doesn't change
ClosedPublic

Authored by epriestley on Feb 21 2014, 4:52 PM.
Tags
None
Referenced Files
F18586660: D8292.id.diff
Thu, Sep 11, 7:20 PM
F18586360: D8292.diff
Thu, Sep 11, 6:21 PM
F18586352: D8292.diff
Thu, Sep 11, 6:21 PM
F18510491: D8292.id.diff
Fri, Sep 5, 4:38 AM
F17958747: D8292.diff
Aug 1 2025, 7:19 AM
F17853985: D8292.id19720.diff
Jul 27 2025, 2:34 PM
F17853983: D8292.id19719.diff
Jul 27 2025, 2:33 PM
F17853982: D8292.id.diff
Jul 27 2025, 2:33 PM
Subscribers

Details

Summary

Fixes T4466. We do an excessively strict effect check now, which means that these fields changing from (string) "16" to (int) 16 generates a transaction. Instead, compare integer values if the field has data in it.

Test Plan

{F116261}

(Also made updates without changing the number, which did not appear in the transaction log anymore.)

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped