Page MenuHomePhabricator

Don't consider integer CustomFields as changed when the number doesn't change
ClosedPublic

Authored by epriestley on Feb 21 2014, 4:52 PM.
Tags
None
Referenced Files
F15407026: D8292.id19719.diff
Tue, Mar 18, 3:14 PM
F15379028: D8292.diff
Thu, Mar 13, 6:16 PM
F15374264: D8292.id19720.diff
Wed, Mar 12, 6:00 PM
F15347917: D8292.diff
Mon, Mar 10, 2:09 PM
F15282755: D8292.diff
Tue, Mar 4, 2:06 AM
Unknown Object (File)
Mon, Feb 24, 12:05 PM
Unknown Object (File)
Feb 17 2025, 1:29 PM
Unknown Object (File)
Feb 17 2025, 1:29 PM
Subscribers

Details

Summary

Fixes T4466. We do an excessively strict effect check now, which means that these fields changing from (string) "16" to (int) 16 generates a transaction. Instead, compare integer values if the field has data in it.

Test Plan

{F116261}

(Also made updates without changing the number, which did not appear in the transaction log anymore.)

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped