Page MenuHomePhabricator

Don't consider integer CustomFields as changed when the number doesn't change
ClosedPublic

Authored by epriestley on Feb 21 2014, 4:52 PM.
Tags
None
Referenced Files
F13340827: D8292.id.diff
Thu, Jun 20, 4:13 AM
F13340506: D8292.id19719.diff
Thu, Jun 20, 2:35 AM
F13339743: D8292.diff
Wed, Jun 19, 8:14 PM
F13335380: D8292.diff
Wed, Jun 19, 1:51 AM
F13319383: D8292.diff
Thu, Jun 13, 12:33 PM
F13233843: D8292.diff
May 21 2024, 2:36 AM
F13216789: D8292.id.diff
May 18 2024, 2:13 AM
F13216445: D8292.diff
May 18 2024, 12:58 AM
Subscribers

Details

Summary

Fixes T4466. We do an excessively strict effect check now, which means that these fields changing from (string) "16" to (int) 16 generates a transaction. Instead, compare integer values if the field has data in it.

Test Plan

{F116261}

(Also made updates without changing the number, which did not appear in the transaction log anymore.)

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped