Page MenuHomePhabricator

Use timeline view in Differential and make inlines somewhat usable again
ClosedPublic

Authored by epriestley on Feb 13 2014, 8:09 PM.
Tags
None
Referenced Files
F13149553: D8215.diff
Sat, May 4, 10:04 AM
Unknown Object (File)
Fri, May 3, 10:42 AM
Unknown Object (File)
Sat, Apr 27, 9:02 PM
Unknown Object (File)
Sat, Apr 27, 9:02 PM
Unknown Object (File)
Sat, Apr 27, 9:02 PM
Unknown Object (File)
Sat, Apr 27, 9:02 PM
Unknown Object (File)
Sat, Apr 27, 9:02 PM
Unknown Object (File)
Sat, Apr 27, 9:02 PM
Subscribers

Details

Summary

Ref T2222. This gets rid of Differential's custom view and uses a standard view instead.

This also mostly fixes the rendering logic for inlines.

This is headed to the tmp.differential branch.

Test Plan

{F112696}

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

src/applications/differential/view/DifferentialTransactionView.php
19–21

I think I can put the grouping stuff in the core after we merge with a method like isThisKindOfTransactionAnInlineComment(), but the rendering I probably can't merge unless we change one of the applications.

epriestley updated this revision to Unknown Object (????).Feb 13 2014, 8:28 PM
  • Fix local anchor.
epriestley updated this revision to Unknown Object (????).Feb 13 2014, 8:50 PM

Fixes T1790.