Ref T2222. This gets rid of Differential's custom view and uses a standard view instead.
This also mostly fixes the rendering logic for inlines.
This is headed to the tmp.differential branch.
Details
Details
- Reviewers
btrahan - Maniphest Tasks
- Restricted Maniphest Task
T2222: Implement ApplicationTransactions in Differential - Commits
- Restricted Diffusion Commit
rP62cb58408346: Use timeline view in Differential and make inlines somewhat usable again
{F112696}
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Branch
- dxn4
- Lint
Lint Passed Severity Location Code Message Advice src/applications/differential/view/DifferentialTransactionView.php:18 XHP16 TODO Comment Advice src/applications/differential/view/DifferentialTransactionView.php:110 XHP16 TODO Comment - Unit
Tests Passed
Event Timeline
| src/applications/differential/view/DifferentialTransactionView.php | ||
|---|---|---|
| 18–20 | I think I can put the grouping stuff in the core after we merge with a method like isThisKindOfTransactionAnInlineComment(), but the rendering I probably can't merge unless we change one of the applications. | |