Ran 'arc browse', 'arc browse .', 'arc browse main.py'.
Details
Details
- Reviewers
epriestley - Group Reviewers
Blessed Reviewers - Commits
- rARC52d3cd1b4ef7: Support browsing '.' and default to it
Diff Detail
Diff Detail
- Repository
- rARC Arcanist
- Branch
- browse-cwd
- Lint
Lint Passed - Unit
No Test Coverage
Event Timeline
Comment Actions
I'm not sure I'd like it to default to .; One thing I find myself doing quite often is:
$ find ... | xargs arc browseWhich would be a little weird (less "unix-y") if it will open the cwd instead of nothing, I think.
Kudos for the bug-fix, though :)
| src/workflow/ArcanistBrowseWorkflow.php | ||
|---|---|---|
| 79–83 | can be written as $this->getArgument('paths', '.'); | |
Comment Actions
Maybe we could give you arc browse --stdin, although that might be a pain to remember.
Comment Actions
I'll just pull the bugfix, I don't feel too strongly about the default behavior of arc browse, and the xargs use cases is a reasonable one.